From 01640bb8d61e5fc4e93e670d51727efb75408b95 Mon Sep 17 00:00:00 2001 From: R Midhun Suresh Date: Wed, 5 Aug 2026 15:43:38 +0530 Subject: [PATCH] Remove code to round newSize on resize (#34543) This never actually fixed the issue of the call elements being blurry due to fractional pixels. But it also causes other issues like the max/min width of the left panel never being persisted in settings. --- .../structures/ResizerViewModel.test.ts | 15 --------------- .../src/viewmodels/structures/ResizerViewModel.ts | 6 ------ 2 files changed, 21 deletions(-) diff --git a/apps/web/src/viewmodels/structures/ResizerViewModel.test.ts b/apps/web/src/viewmodels/structures/ResizerViewModel.test.ts index 050aa916e3..66c45b6e8f 100644 --- a/apps/web/src/viewmodels/structures/ResizerViewModel.test.ts +++ b/apps/web/src/viewmodels/structures/ResizerViewModel.test.ts @@ -147,19 +147,4 @@ describe("LeftPanelResizerViewModel", () => { vm.onLeftPanelResized(50); expect(mockHandle.resize).not.toHaveBeenCalled(); }); - - it("should resize to nearest whole number", () => { - const vm = new ResizerViewModel(CallStore.instance); - const mockHandle = { - resize: vi.fn(), - getSize: vi.fn().mockReturnValue(0), - } as unknown as PanelImperativeHandle; - vm.setPanelHandle(mockHandle); - - // Initial call is ignored - vm.onLeftPanelResized(70); - // This should be processed - vm.onLeftPanelResized(25.515); - expect(mockHandle.resize).toHaveBeenLastCalledWith("26%"); - }); }); diff --git a/apps/web/src/viewmodels/structures/ResizerViewModel.ts b/apps/web/src/viewmodels/structures/ResizerViewModel.ts index 4fa52cb19a..cd85845003 100644 --- a/apps/web/src/viewmodels/structures/ResizerViewModel.ts +++ b/apps/web/src/viewmodels/structures/ResizerViewModel.ts @@ -99,12 +99,6 @@ export class ResizerViewModel this.autoCollapse.onLeftPanelResized(); - // We don't want the panels to have fractional widths as that can cause blurry UI elements. - if (!Number.isInteger(newSize)) { - this.panelHandle?.resize(`${Math.round(newSize)}%`); - return; - } - const isCollapsed = newSize === 0; // Store the size if the panel isn't collapsed. if (!isCollapsed) {