Enable @typescript-eslint/explicit-function-return-type in /src (#9788)

* Enable `@typescript-eslint/explicit-member-accessibility` on /src

* Prettier

* Enable `@typescript-eslint/explicit-function-return-type` in /src

* Fix types

* tsc strict fixes

* Delint

* Fix test

* Fix bad merge
This commit is contained in:
Michael Telatynski
2023-01-12 13:25:14 +00:00
committed by GitHub
parent 7a36ba0fde
commit 030b7e90bf
683 changed files with 3459 additions and 3013 deletions
@@ -26,28 +26,28 @@ import { SettingLevel } from "../../../../settings/SettingLevel";
import { SETTINGS } from "../../../../settings/Settings";
import Field from "../../elements/Field";
const SettingExplorer = ({ onBack }: IDevtoolsProps) => {
const SettingExplorer: React.FC<IDevtoolsProps> = ({ onBack }) => {
const [setting, setSetting] = useState<string>(null);
const [editing, setEditing] = useState(false);
if (setting && editing) {
const onBack = () => {
const onBack = (): void => {
setEditing(false);
};
return <EditSetting setting={setting} onBack={onBack} />;
} else if (setting) {
const onBack = () => {
const onBack = (): void => {
setSetting(null);
};
const onEdit = async () => {
const onEdit = async (): Promise<void> => {
setEditing(true);
};
return <ViewSetting setting={setting} onBack={onBack} onEdit={onEdit} />;
} else {
const onView = (setting: string) => {
const onView = (setting: string): void => {
setSetting(setting);
};
const onEdit = (setting: string) => {
const onEdit = (setting: string): void => {
setSetting(setting);
setEditing(true);
};
@@ -63,7 +63,7 @@ interface ICanEditLevelFieldProps {
roomId?: string;
}
const CanEditLevelField = ({ setting, roomId, level }: ICanEditLevelFieldProps) => {
const CanEditLevelField: React.FC<ICanEditLevelFieldProps> = ({ setting, roomId, level }) => {
const canEdit = SettingsStore.canSetValue(setting, roomId, level);
const className = canEdit ? "mx_DevTools_SettingsExplorer_mutable" : "mx_DevTools_SettingsExplorer_immutable";
return (
@@ -92,14 +92,14 @@ interface IEditSettingProps extends Pick<IDevtoolsProps, "onBack"> {
setting: string;
}
const EditSetting = ({ setting, onBack }: IEditSettingProps) => {
const EditSetting: React.FC<IEditSettingProps> = ({ setting, onBack }) => {
const context = useContext(DevtoolsContext);
const [explicitValue, setExplicitValue] = useState(renderExplicitSettingValues(setting, null));
const [explicitRoomValue, setExplicitRoomValue] = useState(
renderExplicitSettingValues(setting, context.room.roomId),
);
const onSave = async () => {
const onSave = async (): Promise<string> => {
try {
const parsedExplicit = JSON.parse(explicitValue);
const parsedExplicitRoom = JSON.parse(explicitRoomValue);
@@ -203,7 +203,7 @@ interface IViewSettingProps extends Pick<IDevtoolsProps, "onBack"> {
onEdit(): Promise<void>;
}
const ViewSetting = ({ setting, onEdit, onBack }: IViewSettingProps) => {
const ViewSetting: React.FC<IViewSettingProps> = ({ setting, onEdit, onBack }) => {
const context = useContext(DevtoolsContext);
return (
@@ -261,7 +261,7 @@ interface ISettingsListProps extends Pick<IDevtoolsProps, "onBack"> {
onEdit(setting: string): void;
}
const SettingsList = ({ onBack, onView, onEdit }: ISettingsListProps) => {
const SettingsList: React.FC<ISettingsListProps> = ({ onBack, onView, onEdit }) => {
const context = useContext(DevtoolsContext);
const [query, setQuery] = useState("");