sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Deflake new device-dehydration test (#34114)

Browse Source 
* Deflake new device-dehydration test

* Add some comments
This commit is contained in:
Richard van der Hoff
2026-07-03 10:17:42 +00:00
committed by GitHub
parent 275ea25eca
commit 0c0cb5df3d
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/playwright/e2e/crypto/dehydration.spec.ts
+17 -6
View File
@@ -19,6 +19,7 @@ import {
} from "./utils.ts"; } from "./utils.ts";
import { type Client } from "../../pages/client.ts"; import { type Client } from "../../pages/client.ts";
import { type ElementAppPage } from "../../pages/ElementAppPage.ts"; import { type ElementAppPage } from "../../pages/ElementAppPage.ts";
import { Bot } from "../../pages/bot.ts";
const NAME = "Alice"; const NAME = "Alice";
@@ -119,18 +120,24 @@ test.describe("Dehydration", () => {
await expectDehydratedDeviceDisabled(app); await expectDehydratedDeviceDisabled(app);
}); });
test("Can read messages sent while logged out", async ({ page, user: credentials, app, bot: bob }) => { test("Can read messages sent while logged out", async ({ homeserver, credentials, page, app }) => {
const recoveryKey = const recoveryKey =
await test.step("Alice sets up cross-signing and recovery => a dehydrated device is created", async () => { await test.step("Alice logs in and sets up recovery => a dehydrated device is created", async () => {
// Create an identity, then set up recovery, to create a dehydrated device. // This test does a page reload to work around a bug, so we need to avoid the `pageWithCredentials` and `user`
await app.client.bootstrapCrossSigning(credentials); // fixtures poke credentials into localStorage via a pageload script. We therefore log in manually.
await logIntoElement(page, credentials);
// Logging in will have created a cross-signing identity for us. Now set up recovery, to create a dehydrated device.
const recoveryKey = await enableKeyBackup(app); const recoveryKey = await enableKeyBackup(app);
await expectDehydratedDeviceEnabled(app); await expectDehydratedDeviceEnabled(app);
return recoveryKey; return recoveryKey;
}); });
const testRoomId = await test.step("Bob and Alice make a shared room", async () => { const [bob, testRoomId] = await test.step("Bob and Alice make a shared room", async () => {
// As above, we need to avoid the `user` fixture: we therefore also need to avoid the `bot` fixture, which
// depends on the `user` fixture. We just create the bot manually.
const bob = new Bot(page, homeserver, { displayName: "Bob" });
await autoJoin(bob); await autoJoin(bob);
// create an encrypted room, and wait for Bob to join it. // create an encrypted room, and wait for Bob to join it.
@@ -138,7 +145,7 @@ test.describe("Dehydration", () => {
// Even though Alice has seen Bob's join event, Bob may not have done so yet. Wait for the sync to arrive. // Even though Alice has seen Bob's join event, Bob may not have done so yet. Wait for the sync to arrive.
await bob.awaitRoomMembership(testRoomId); await bob.awaitRoomMembership(testRoomId);
return testRoomId; return [bob, testRoomId];
}); });
await test.step("Alice logs out", async () => { await test.step("Alice logs out", async () => {
@@ -150,6 +157,10 @@ test.describe("Dehydration", () => {
}); });
await test.step("Alice logs back in, and should be able to view Bob's message", async () => { await test.step("Alice logs back in, and should be able to view Bob's message", async () => {
// Reload to work around a Rust crypto bug where it can hold onto the indexeddb even after logout
// https://github.com/element-hq/element-web/issues/25779
await page.reload();
await logIntoElement(page, credentials); await logIntoElement(page, credentials);
await verifyAfterLogin(page, recoveryKey); await verifyAfterLogin(page, recoveryKey);
await app.viewRoomById(testRoomId); await app.viewRoomById(testRoomId);