sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Avoid excessive re-render when setting same reference/value in snapshot (#32918)

Browse Source 
* perf: avoid excessive re-render when setting same value in snapshot

* test: update tests
This commit is contained in:
Florian Duros
2026-03-25 15:23:11 +00:00
committed by GitHub
parent d0a564d578
commit 1025d60001
5 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/test/viewmodels/message-body/EventContentBodyViewModel-test.tsx
+2 -2
View File
@@ -280,7 +280,7 @@ describe("EventContentBodyViewModel", () => {
expect(vm.getSnapshot().body).toBe("Updated");
});
it("emits updates when setters are called with unchanged values", () => {
it("doesn't emit updates when setters are called with unchanged values", () => {
const replacer = jest.fn();
mockedCombineRenderers.mockReturnValue(() => replacer);
mockedBodyToNode.mockReturnValue({
@@ -298,7 +298,7 @@ describe("EventContentBodyViewModel", () => {
vm.setEventContent(undefined, defaultContent);
vm.setAs("span");
expect(subscriber).toHaveBeenCalledTimes(2);
expect(subscriber).toHaveBeenCalledTimes(0);
expect(vm.getSnapshot()).toEqual(previousSnapshot);
});