Update scripts for compatibility with latest NodeJS Security Release (#1628)

Co-authored-by: David Baker <dbkr@users.noreply.github.com>
2024-04-17 15:12:29 +01:00
parent d1fd69f938
commit 193de5182f
4 changed files with 17 additions and 0 deletions
@@ -53,6 +53,9 @@ export default async function link(hakEnv: HakEnv, moduleInfo: DependencyInfo):
        const proc = childProcess.spawn(yarnCmd, ["link"], {
            cwd: moduleInfo.moduleOutDir,
            stdio: "inherit",
+            // We need shell mode on Windows to be able to launch `.cmd` executables
+            // See https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
+            shell: hakEnv.isWin(),
        });
        proc.on("exit", (code) => {
            code ? reject(code) : resolve();
@@ -63,6 +66,9 @@ export default async function link(hakEnv: HakEnv, moduleInfo: DependencyInfo):
        const proc = childProcess.spawn(yarnCmd, ["link", moduleInfo.name], {
            cwd: hakEnv.projectRoot,
            stdio: "inherit",
+            // We need shell mode on Windows to be able to launch `.cmd` executables
+            // See https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
+            shell: hakEnv.isWin(),
        });
        proc.on("exit", (code) => {
            code ? reject(code) : resolve();