sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Fix the logic and comments surrounding the e2e test: "should open the notification options menu" (#31853)

Browse Source 
* fix the logic and comments surrounding the e2e test

* spacing

* prettier
This commit is contained in:
David Langley
2026-01-22 19:20:36 +00:00
committed by GitHub
parent 3fc3653809
commit 19cfddab6d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
playwright/e2e/left-panel/room-list-panel/room-list.spec.ts
+5 -5
View File
@@ -121,23 +121,23 @@ test.describe("Room list", () => {
// It should make the room muted // It should make the room muted
await page.getByRole("menuitem", { name: "Mute room" }).click(); await page.getByRole("menuitem", { name: "Mute room" }).click();
await expect(roomItem.getByTestId("notification-decoration")).not.toBeVisible(); // Not hovered, the room decoration should be the muted icon
await expect(roomItem.getByTestId("notification-decoration")).toBeVisible();
// Put focus on the room list // Put focus on the room list
await roomListView.getByRole("option", { name: "Open room room28" }).click(); await roomListView.getByRole("option", { name: "Open room room28" }).click();
// Scroll to the end of the room list // During hover the room decoration should still be the muted icon
await app.scrollListToBottom(roomListView);
// The room decoration should have the muted icon
await expect(roomItem.getByTestId("notification-decoration")).toBeVisible(); await expect(roomItem.getByTestId("notification-decoration")).toBeVisible();
await roomItem.hover(); await roomItem.hover();
// On hover, the room should show the muted icon // On hover, the room should show the muted icon
await expect(roomItem).toMatchScreenshot("room-list-item-hover-silent.png"); await expect(roomItem).toMatchScreenshot("room-list-item-hover-silent.png");
roomItemMenu = roomItem.getByRole("button", { name: "Notification options" }); roomItemMenu = roomItem.getByRole("button", { name: "Notification options" });
await roomItemMenu.click(); await roomItemMenu.click();
// The Mute room option should be selected // The Mute room option should be selected
await expect(page.getByRole("menuitem", { name: "Mute room" })).toHaveAttribute("aria-selected", "true"); await expect(page.getByRole("menuitem", { name: "Mute room" })).toHaveAttribute("aria-selected", "true");
await expect(page).toMatchScreenshot("room-list-item-open-notification-options-selection.png"); await expect(page).toMatchScreenshot("room-list-item-open-notification-options-selection.png");