sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Start voice call in PiP (not in fullscreen) (#34055)

Browse Source 
* start voice call in pip

* Update jest.config.ts

* fix "join" button to use correct intent

* Add regression test for join button

* Update RoomHeader-test.tsx

* fmt

* Add playwright test

* Fix expected intent on "join" button press

* Add additional pip check to exising:
`should be able to join a ${callType} call in progress` test

* Update RoomHeader-test.tsx
This commit is contained in:
Timo
2026-07-06 15:57:26 +00:00
committed by GitHub
parent 3153912cc1
commit 20587b3495
5 changed files with 123 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/test/unit-tests/stores/RoomViewStore-test.ts
+56 -1
View File
@@ -48,7 +48,8 @@ import { CallStore } from "../../../src/stores/CallStore";
import { MatrixClientPeg } from "../../../src/MatrixClientPeg";
import MediaDeviceHandler, { MediaDeviceKindEnum } from "../../../src/MediaDeviceHandler";
import { storeRoomAliasInCache } from "../../../src/RoomAliasCache.ts";
import { type Call } from "../../../src/models/Call.ts";
import { type Call, ConnectionState } from "../../../src/models/Call.ts";
import ActiveWidgetStore from "../../../src/stores/ActiveWidgetStore";
import { ModuleApi } from "../../../src/modules/Api";
jest.mock("../../../src/Modal");
@@ -430,6 +431,60 @@ describe("RoomViewStore", function () {
expect(call.presented).toEqual(true);
});
it("opens a voice-intent call directly in picture-in-picture rather than maximised", async () => {
const call = {
presented: false,
connectionState: ConnectionState.Disconnected,
widget: { id: "!widget:example.org" },
start: jest.fn(),
} as unknown as Call;
jest.spyOn(CallStore.instance, "getCall").mockReturnValue(call);
const persistenceSpy = jest.spyOn(ActiveWidgetStore.instance, "setWidgetPersistence");
await setupAsyncStoreWithClient(CallStore.instance, MatrixClientPeg.safeGet());
dis.dispatch<ViewRoomPayload>({
action: Action.ViewRoom,
room_id: roomId,
view_call: true,
voiceOnly: true,
metricsTrigger: undefined,
});
await untilDispatch(Action.ViewRoom, dis);
// The call is started and marked persistent so it renders in the PiP container...
expect(call.presented).toEqual(true);
expect(persistenceSpy).toHaveBeenCalledWith("!widget:example.org", roomId, true);
expect(call.start).toHaveBeenCalledWith(expect.objectContaining({ voiceOnly: true }));
// ...but the room is not switched to the maximised call view.
expect(roomViewStore.isViewingCall()).toEqual(false);
});
it("opens a video-intent call maximised in the room", async () => {
const call = {
presented: false,
connectionState: ConnectionState.Disconnected,
widget: { id: "!widget:example.org" },
start: jest.fn(),
} as unknown as Call;
jest.spyOn(CallStore.instance, "getCall").mockReturnValue(call);
const persistenceSpy = jest.spyOn(ActiveWidgetStore.instance, "setWidgetPersistence");
await setupAsyncStoreWithClient(CallStore.instance, MatrixClientPeg.safeGet());
dis.dispatch<ViewRoomPayload>({
action: Action.ViewRoom,
room_id: roomId,
view_call: true,
voiceOnly: false,
metricsTrigger: undefined,
});
await untilDispatch(Action.ViewRoom, dis);
expect(call.presented).toEqual(true);
expect(persistenceSpy).not.toHaveBeenCalled();
expect(call.start).toHaveBeenCalledWith(expect.objectContaining({ voiceOnly: false }));
expect(roomViewStore.isViewingCall()).toEqual(true);
});
it("should display an error message when the room is unreachable via the roomId", async () => {
// When
// View and wait for the room