Remove flaky test : left-panel/room-list-panel/room-list-filter-sort.spec.ts: should scroll to the top of list when filter is applied and active room is not in filtered list (#32587)
* test: do expect in a poll to add robustness to room list scroll test To fix https://github.com/element-hq/element-web/issues/30606 * test: removing the flaky test, behaviour is inconsistent and can't make it work
This commit is contained in:
@@ -109,55 +109,6 @@ test.describe("Room list filters and sort", () => {
|
|||||||
await expect(oldRoomTile).not.toBeVisible();
|
await expect(oldRoomTile).not.toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
test.describe("Scroll behaviour", () => {
|
|
||||||
test("should scroll to the top of list when filter is applied and active room is not in filtered list", async ({
|
|
||||||
page,
|
|
||||||
app,
|
|
||||||
}) => {
|
|
||||||
const createFavouriteRoom = async (name: string) => {
|
|
||||||
const id = await app.client.createRoom({
|
|
||||||
name,
|
|
||||||
});
|
|
||||||
await app.client.evaluate(async (client, favouriteId) => {
|
|
||||||
await client.setRoomTag(favouriteId, "m.favourite", { order: 0.5 });
|
|
||||||
}, id);
|
|
||||||
};
|
|
||||||
|
|
||||||
// Create 5 favourite rooms
|
|
||||||
let i = 0;
|
|
||||||
for (; i < 5; i++) {
|
|
||||||
await createFavouriteRoom(`room${i}-fav`);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Create a non-favourite room
|
|
||||||
await app.client.createRoom({ name: `room-non-fav` });
|
|
||||||
|
|
||||||
// Create rest of the favourite rooms
|
|
||||||
for (; i < 20; i++) {
|
|
||||||
await createFavouriteRoom(`room${i}-fav`);
|
|
||||||
}
|
|
||||||
|
|
||||||
// Open the non-favourite room
|
|
||||||
const roomListView = getRoomList(page);
|
|
||||||
const tile = roomListView.getByRole("option", { name: "Open room room-non-fav" });
|
|
||||||
// item may not be in the DOM using scrollListToBottom rather than scrollIntoViewIfNeeded
|
|
||||||
await app.scrollListToBottom(roomListView);
|
|
||||||
await tile.click();
|
|
||||||
|
|
||||||
// Enable Favourite filter
|
|
||||||
await getFilterExpandButton(page).click();
|
|
||||||
const primaryFilters = getPrimaryFilters(page);
|
|
||||||
await primaryFilters.getByRole("option", { name: "Favourite" }).click();
|
|
||||||
await expect(tile).not.toBeVisible();
|
|
||||||
|
|
||||||
// Ensure the room list is not scrolled
|
|
||||||
const isScrolledDown = await page
|
|
||||||
.getByRole("listbox", { name: "Room list", exact: true })
|
|
||||||
.evaluate((e) => e.scrollTop !== 0);
|
|
||||||
expect(isScrolledDown).toStrictEqual(false);
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|
||||||
test.describe("Room list", () => {
|
test.describe("Room list", () => {
|
||||||
let unReadDmId: string | undefined;
|
let unReadDmId: string | undefined;
|
||||||
let unReadRoomId: string | undefined;
|
let unReadRoomId: string | undefined;
|
||||||
|
|||||||
Reference in New Issue
Block a user