From 2af8e3c21f7fe1b265cc3009364897127e8204a5 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff Date: Tue, 4 Nov 2025 23:49:31 +0000 Subject: [PATCH] Warn about linked node modules under podman Thanks to a podman bug, the symlink workaround doesn't work there. Let's emit a noisy warning. --- .../playwright-screenshots.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/element-web-playwright-common/playwright-screenshots.sh b/packages/element-web-playwright-common/playwright-screenshots.sh index 6b927f7cf5..99d8d1fb4b 100755 --- a/packages/element-web-playwright-common/playwright-screenshots.sh +++ b/packages/element-web-playwright-common/playwright-screenshots.sh @@ -91,6 +91,18 @@ popd > /dev/null for LINK in $SYMLINKS; do TARGET=$(readlink -f "node_modules/$LINK") || true if [ -d "$TARGET" ]; then + if docker --version | grep -q podman; then + echo -e "\033[31m" >&2 + cat <<'EOF' >&2 +WARNING: `node_modules` contains symlinks, and the support for this in +`playwright-screenshots.sh` is broken under podman due to +https://github.com/containers/podman/issues/25947. + +If you get errors such as 'Error: crun: creating ``', then retry this +having `yarn unlink`ed the relevant node modules. +EOF + echo -e "\033[0m" >&2 + fi echo "mounting linked package ${LINK:2} in container" RUN_ARGS+=( "-v" "$TARGET:/work/node_modules/${LINK:2}" ) fi