Stabilise Cypress login tests (#9446)

* Attempt to stabilise login tests

* More stability

* Stabilise s'more

* don't clear LS as we rely on it for enablements

* Add small delay

* Iterate

* Update login.ts

cypress/support/login.ts

@@ -91,7 +91,7 @@ Cypress.Commands.add("loginUser", (synapse: SynapseInstance, username: string, p
 Cypress.Commands.add("initTestUser", (synapse: SynapseInstance, displayName: string, prelaunchFn?: () => void): Chainable<UserCredentials> => {
     // XXX: work around Cypress not clearing IDB between tests
     cy.window({ log: false }).then(win => {
-        win.indexedDB.databases().then(databases => {
+        win.indexedDB.databases()?.then(databases => {
             databases.forEach(database => {
                 win.indexedDB.deleteDatabase(database.name);
             });

cypress/support/settings.ts

@@ -153,7 +153,7 @@ Cypress.Commands.add("openRoomSettings", (tab?: string): Chainable<JQuery<HTMLEl
 
 Cypress.Commands.add("switchTab", (tab: string): Chainable<JQuery<HTMLElement>> => {
     return cy.get(".mx_TabbedView_tabLabels").within(() => {
-        cy.get(".mx_TabbedView_tabLabel").contains(tab).click();
+        cy.contains(".mx_TabbedView_tabLabel", tab).click();
     });
 });
 
@@ -162,13 +162,13 @@ Cypress.Commands.add("closeDialog", (): Chainable<JQuery<HTMLElement>> => {
 });
 
 Cypress.Commands.add("joinBeta", (name: string): Chainable<JQuery<HTMLElement>> => {
-    return cy.get(".mx_BetaCard_title").contains(name).closest(".mx_BetaCard").within(() => {
+    return cy.contains(".mx_BetaCard_title", name).closest(".mx_BetaCard").within(() => {
         return cy.get(".mx_BetaCard_buttons").contains("Join the beta").click();
     });
 });
 
 Cypress.Commands.add("leaveBeta", (name: string): Chainable<JQuery<HTMLElement>> => {
-    return cy.get(".mx_BetaCard_title").contains(name).closest(".mx_BetaCard").within(() => {
+    return cy.contains(".mx_BetaCard_title", name).closest(".mx_BetaCard").within(() => {
         return cy.get(".mx_BetaCard_buttons").contains("Leave the beta").click();
     });
 });