sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Fix shared-components storybook:update script (#32486)

Browse Source 
It was failing due to being unable to access pnpm-workspace.yaml so change the docker context to the root of the monorepo

Also disable pnpm-link script in the docker env and node-linking for storybook tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski
2026-02-12 15:59:01 +00:00
committed by GitHub
parent 838b3624b8
commit 2ee6933cfd
5 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/shared-components/package.json
+1 -1
View File
@@ -40,7 +40,7 @@
"i18n:lint": "matrix-i18n-lint && prettier --log-level=silent --write src/i18n/strings/ --ignore-path /dev/null", "i18n:lint": "matrix-i18n-lint && prettier --log-level=silent --write src/i18n/strings/ --ignore-path /dev/null",
"test:unit": "vitest --project=unit", "test:unit": "vitest --project=unit",
"test:storybook": "pnpm build:doc && vitest --project=storybook", "test:storybook": "pnpm build:doc && vitest --project=storybook",
"test:storybook:update": "playwright-screenshots --entrypoint /work/scripts/storybook-screenshot-update.sh --with-node-modules", "test:storybook:update": "cd ../.. && playwright-screenshots --entrypoint /work/packages/shared-components/scripts/storybook-screenshot-update.sh --with-node-modules --no-link-modules",
"build": "vite build", "build": "vite build",
"prepack": "pnpm run build", "prepack": "pnpm run build",
"storybook": "storybook dev -p 6007", "storybook": "storybook dev -p 6007",
packages/shared-components/scripts/storybook-screenshot-update.sh
+2 -2
View File
@@ -13,7 +13,7 @@ set -e
# because we have which must be built for the right architecture (and some environments use a VM # because we have which must be built for the right architecture (and some environments use a VM
# to run docker containers, meaning that things inside a container use a different architecture than # to run docker containers, meaning that things inside a container use a different architecture than
# those on the host). # those on the host).
pnpm install pnpm install --frozen-lockfile
# Now run the screenshot update, we set CI=1 to inform vis to update the real baselines # Now run the screenshot update, we set CI=1 to inform vis to update the real baselines
CI=1 /work/node_modules/.bin/vitest --run --update --project=storybook "$@" CI=1 pnpm --dir packages/shared-components test:storybook --run --update
pnpm-lock.yaml
Generated
+11 -11
View File
@@ -10,8 +10,8 @@ catalogs:
specifier: 1.9.0 specifier: 1.9.0
version: 1.9.0 version: 1.9.0
'@element-hq/element-web-playwright-common': '@element-hq/element-web-playwright-common':
specifier: 2.2.6 specifier: 2.2.7
version: 2.2.6 version: 2.2.7
'@playwright/test': '@playwright/test':
specifier: 1.58.1 specifier: 1.58.1
version: 1.58.1 version: 1.58.1
@@ -222,7 +222,7 @@ importers:
version: 1.0.3 version: 1.0.3
matrix-js-sdk: matrix-js-sdk:
specifier: github:matrix-org/matrix-js-sdk#develop specifier: github:matrix-org/matrix-js-sdk#develop
version: https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/872ec6755e7f3e80b03d815ef13ac42b37dae818 version: https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/327d2fa7c8dca5c881969ca0a4ce279c36389750
matrix-widget-api: matrix-widget-api:
specifier: ^1.16.1 specifier: ^1.16.1
version: 1.17.0 version: 1.17.0
@@ -361,7 +361,7 @@ importers:
version: 0.16.3 version: 0.16.3
'@element-hq/element-web-playwright-common': '@element-hq/element-web-playwright-common':
specifier: 'catalog:' specifier: 'catalog:'
version: 2.2.6(@element-hq/element-web-module-api@1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4))(@playwright/test@1.58.1)(playwright-core@1.58.1) version: 2.2.7(@element-hq/element-web-module-api@1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4))(@playwright/test@1.58.1)(playwright-core@1.58.1)
'@fetch-mock/jest': '@fetch-mock/jest':
specifier: ^0.2.20 specifier: ^0.2.20
version: 0.2.20(@jest/globals@30.2.0)(jest@30.2.0(@types/node@22.19.8)(babel-plugin-macros@3.1.0)) version: 0.2.20(@jest/globals@30.2.0)(jest@30.2.0(@types/node@22.19.8)(babel-plugin-macros@3.1.0))
@@ -746,7 +746,7 @@ importers:
devDependencies: devDependencies:
'@element-hq/element-web-playwright-common': '@element-hq/element-web-playwright-common':
specifier: 'catalog:' specifier: 'catalog:'
version: 2.2.6(@element-hq/element-web-module-api@1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4))(@playwright/test@1.58.1)(playwright-core@1.58.1) version: 2.2.7(@element-hq/element-web-module-api@1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4))(@playwright/test@1.58.1)(playwright-core@1.58.1)
'@fetch-mock/vitest': '@fetch-mock/vitest':
specifier: ^0.2.18 specifier: ^0.2.18
version: 0.2.18(vitest@4.0.18) version: 0.2.18(vitest@4.0.18)
@@ -1996,8 +1996,8 @@ packages:
matrix-web-i18n: matrix-web-i18n:
optional: true optional: true
'@element-hq/element-web-playwright-common@2.2.6': '@element-hq/element-web-playwright-common@2.2.7':
resolution: {integrity: sha512-Rd+bjnV1ZX1r6qWB5ebcluBepqgUWlYvxaqaaSOnMdGoXkkA6j0i4ctQDN7frP58p5/njo4xejPfd2H3Runfyw==} resolution: {integrity: sha512-YMvhIHKqjwlaHe6bo7wCIer7nIc2cRqXAYjKVrGmHiKSeBP+E+qw5LuOSM20u7+0SHyRnC/IR3/Up63O81Qhyw==}
engines: {node: '>=20.0.0'} engines: {node: '>=20.0.0'}
hasBin: true hasBin: true
peerDependencies: peerDependencies:
@@ -7676,8 +7676,8 @@ packages:
matrix-events-sdk@0.0.1: matrix-events-sdk@0.0.1:
resolution: {integrity: sha512-1QEOsXO+bhyCroIe2/A5OwaxHvBm7EsSQ46DEDn8RBIfQwN5HWBpFvyWWR4QY0KHPPnnJdI99wgRiAl7Ad5qaA==} resolution: {integrity: sha512-1QEOsXO+bhyCroIe2/A5OwaxHvBm7EsSQ46DEDn8RBIfQwN5HWBpFvyWWR4QY0KHPPnnJdI99wgRiAl7Ad5qaA==}
matrix-js-sdk@https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/872ec6755e7f3e80b03d815ef13ac42b37dae818: matrix-js-sdk@https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/327d2fa7c8dca5c881969ca0a4ce279c36389750:
resolution: {tarball: https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/872ec6755e7f3e80b03d815ef13ac42b37dae818} resolution: {tarball: https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/327d2fa7c8dca5c881969ca0a4ce279c36389750}
version: 40.2.0 version: 40.2.0
engines: {node: '>=22.0.0'} engines: {node: '>=22.0.0'}
@@ -11831,7 +11831,7 @@ snapshots:
'@matrix-org/react-sdk-module-api': 2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4) '@matrix-org/react-sdk-module-api': 2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4)
matrix-web-i18n: 3.6.0 matrix-web-i18n: 3.6.0
'@element-hq/element-web-playwright-common@2.2.6(@element-hq/element-web-module-api@1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4))(@playwright/test@1.58.1)(playwright-core@1.58.1)': '@element-hq/element-web-playwright-common@2.2.7(@element-hq/element-web-module-api@1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4))(@playwright/test@1.58.1)(playwright-core@1.58.1)':
dependencies: dependencies:
'@axe-core/playwright': 4.11.1(playwright-core@1.58.1) '@axe-core/playwright': 4.11.1(playwright-core@1.58.1)
'@element-hq/element-web-module-api': 1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4) '@element-hq/element-web-module-api': 1.9.0(@matrix-org/react-sdk-module-api@2.5.0(patch_hash=016146c9cc96e6363609d2b2ac0896ccef567882eb1d73b75a77b8a30929de96)(react@19.2.4))(@types/react-dom@19.2.3(@types/react@19.2.10))(@types/react@19.2.10)(matrix-web-i18n@3.6.0)(react@19.2.4)
@@ -18434,7 +18434,7 @@ snapshots:
matrix-events-sdk@0.0.1: {} matrix-events-sdk@0.0.1: {}
matrix-js-sdk@https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/872ec6755e7f3e80b03d815ef13ac42b37dae818: matrix-js-sdk@https://codeload.github.com/matrix-org/matrix-js-sdk/tar.gz/327d2fa7c8dca5c881969ca0a4ce279c36389750:
dependencies: dependencies:
'@babel/runtime': 7.28.6 '@babel/runtime': 7.28.6
'@matrix-org/matrix-sdk-crypto-wasm': 17.1.0 '@matrix-org/matrix-sdk-crypto-wasm': 17.1.0
pnpm-workspace.yaml
+1 -1
View File
@@ -14,7 +14,7 @@ catalog:
"@types/react": ^19.2.10 "@types/react": ^19.2.10
"@types/react-dom": ^19.2.3 "@types/react-dom": ^19.2.3
# playwright # playwright
"@element-hq/element-web-playwright-common": 2.2.6 "@element-hq/element-web-playwright-common": 2.2.7
"@playwright/test": 1.58.1 "@playwright/test": 1.58.1
# Module API # Module API
"@element-hq/element-web-module-api": 1.9.0 "@element-hq/element-web-module-api": 1.9.0
scripts/pnpm-link.ts
+2
View File
@@ -23,6 +23,8 @@ const configPath = join(__dirname, "..", ".link-config");
const nodeModulesPath = join(__dirname, "..", "node_modules"); const nodeModulesPath = join(__dirname, "..", "node_modules");
try { try {
if (process.env.PLAYWRIGHT_COMMON_DOCKER) process.exit(0); // Skip in docker env
const configFile = await fs.readFile(configPath, "utf-8"); const configFile = await fs.readFile(configPath, "utf-8");
for (const line of configFile.trim().split("\n")) { for (const line of configFile.trim().split("\n")) {
const [dependency, path] = line.split("="); const [dependency, path] = line.split("=");