sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Improve decryption error UI by consolidating error messages and providing instructions when possible (#9544)

Browse Source 
* Improve decryption error UI by consolidating error messages and providing instructions when possible

* Fix TS strict errors

* Rename .scss to .pcss

* Avoid accessing clipboard, Cypress doesn't like it

* Display DecryptionFailureBar alongside other AuxPanel bars

* Add comments

* Add small margin off-screen for visible decryption failures

* Fix some more TS strict errors

* Add unit tests for DecryptionFailureBar

* Add button to resend key requests manually

* Remove references to matrix-js-sdk crypto internals

* Add hysteresis to visible decryption failures

* Add comment

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Add comment

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Don't create empty div if we're not showing resend requests button

* cancel updateSessions on unmount

* Update unit tests

* Fix lint and implicit any

* Simplify visible event bounds checking

* Adjust cypress test descriptions

* Add percy snapshots

* Update src/components/structures/TimelinePanel.tsx

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Add comments on TimelinePanel IState

* comment

* Add names to percy snapshots

* Show Resend Key Requests button when there are sessions that haven't already been requested via this bar

* We no longer request keys from senders

* update i18n

* update expected text in cypress test

* don't download keys ourselves, update device info in response to updates from client

* fix ts strict errors

* visibledecryptionfailures undefined handling

* Fix implicitAny errors

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Faye Duxovni
2022-12-15 17:24:33 +00:00
committed by GitHub
co-authored by Richard van der Hoff Michael Telatynski
parent b728b27435
commit 4724506320
18 changed files with 1779 additions and 165 deletions
Download Patch File Download Diff File Expand all files Collapse all files
res/css/views/rooms/_EventTile.pcss
+5 -27
View File
@@ -685,6 +685,11 @@ $left-gutter: 64px;
mask-image: url("$(res)/img/e2e/normal.svg");
background-color: $header-panel-text-primary-color;
}
&.mx_EventTile_e2eIcon_decryption_failure::after {
mask-image: url("$(res)/img/e2e/decryption-failure.svg");
background-color: $secondary-content;
}
}
.mx_EventTile_body {
@@ -793,33 +798,6 @@ $left-gutter: 64px;
mask-image: url("$(res)/img/element-icons/maximise-expand.svg");
}
.mx_EventTile_keyRequestInfo {
font-size: $font-12px;
.mx_EventTile_keyRequestInfo_text {
opacity: 0.5;
.mx_AccessibleButton {
color: $primary-content;
text-decoration: underline;
}
}
}
.mx_EventTile_keyRequestInfo_tooltip_contents p {
text-align: auto;
margin-left: 3px;
margin-right: 3px;
&:first-child {
margin-top: 0px;
}
&:last-child {
margin-bottom: 0px;
}
}
.mx_EventTile_tileError {
color: red;
text-align: center;