Enable oxlint restriction ruleset (#34307)

* Remove stale max-len disablements

* Remove stale camelCase & naming-convention disablements

* Remove stale ban-ts-comment disablements

* Remove stale no-var disablements

* Remove stale no-empty-property disablements

* Remove stale react rule disablements

* Remove stale no-constant-condition disablements

* Remove stale no-unused-vars disablements

* Remove stale disablements for disabled rules

* fixup camelcase

* Remove dead code

* Tidy code

* Tweak oxlint config

* Use oxlint to apply jsx/tsx extension consistently

* Fix import

* Fix imports

* Rename affected snapshots

* Update more imports

* Enable restriction ruleset

* Make code comply with new rules

* Make code comply with react/button-has-type

* Make code comply with typescript/non-nullable-type-assertion-style

* Comply with node/no-process-env

* Comply with unicorn/prefer-node-protocol

* Comply with unicorn/import-style

* Comply with unicorn/no-process-exit

* Comply with no-proto

* Comply with node/handle-callback-err

* Comply with import/no-commonjs

* Comply with node/no-path-concat

* Comply with unicorn/no-length-as-slice-end

* Comply with unicorn/no-document-cookie

* Comply with unicorn/prefer-module

* Comply with typescript/prefer-literal-enum-member

* Comply with jsx-a11y/anchor-ambiguous-text

* Tweak oxlint config

* Fix resolves

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

apps/web/test/unit-tests/components/views/dialogs/BaseDialog-test.tsx

@@ -18,7 +18,7 @@ describe("BaseDialog", () => {
         // Autolock's autofocus in the empty dialog is focusing on the close button and bringing up the tooltip
         // So we either need to call escape twice(one for the tooltip and one for the dialog) or focus
         // on the dialog first.
-        const dialog = container.querySelector('[role="dialog"]') as HTMLElement;
+        const dialog = container.querySelector<HTMLElement>('[role="dialog"]')!;
         dialog?.focus();
         await userEvent.keyboard("{Escape}");
         expect(onFinished).toHaveBeenCalled();

apps/web/test/unit-tests/components/views/dialogs/__snapshots__/DevtoolsDialog-test.tsx.snap

@@ -76,41 +76,49 @@ exports[`DevtoolsDialog renders the devtools dialog 1`] = `
         </h2>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Send custom timeline event
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Explore room state
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Explore room account data
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           View servers in room
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Notifications debug
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Active Widgets
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Users
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Explore sticky state
         </button>
@@ -123,21 +131,25 @@ exports[`DevtoolsDialog renders the devtools dialog 1`] = `
         </h2>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Explore account data
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Settings explorer
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           Server info
         </button>
         <button
           class="mx_DevTools_button"
+          type="button"
         >
           End-to-end encryption
         </button>
@@ -317,7 +329,9 @@ exports[`DevtoolsDialog renders the devtools dialog 1`] = `
     <div
       class="mx_Dialog_buttons"
     >
-      <button>
+      <button
+        type="button"
+      >
         Back
       </button>
     </div>

apps/web/test/unit-tests/components/views/dialogs/devtools/__snapshots__/Event-test.tsx.snap

@@ -51,10 +51,14 @@ exports[`<EventEditor /> should render 1`] = `
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
-    <button>
+    <button
+      type="button"
+    >
       Send
     </button>
   </div>
@@ -115,10 +119,14 @@ exports[`<EventEditor /> thread context should pre-populate a thread relationshi
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
-    <button>
+    <button
+      type="button"
+    >
       Send
     </button>
   </div>

apps/web/test/unit-tests/components/views/dialogs/devtools/__snapshots__/RoomNotifications-test.tsx.snap

@@ -64,7 +64,9 @@ exports[`<RoomNotifications /> should render 1`] = `
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
   </div>

apps/web/test/unit-tests/components/views/dialogs/devtools/__snapshots__/Users-test.tsx.snap

@@ -185,7 +185,9 @@ exports[`<Users /> should render a single device - signed by owner 1`] = `
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
   </div>
@@ -377,7 +379,9 @@ exports[`<Users /> should render a single device - unsigned 1`] = `
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
   </div>
@@ -571,7 +575,9 @@ exports[`<Users /> should render a single device - verified by cross-signing 1`]
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
   </div>
@@ -672,6 +678,7 @@ exports[`<Users /> should render a single user 1`] = `
         <li>
           <button
             class="mx_DevTools_button"
+            type="button"
           >
             <div
               class="mx_E2EIcon mx_E2EIcon_inline"
@@ -698,6 +705,7 @@ exports[`<Users /> should render a single user 1`] = `
         <li>
           <button
             class="mx_DevTools_button"
+            type="button"
           >
             <div
               class="mx_E2EIcon mx_E2EIcon_inline"
@@ -722,6 +730,7 @@ exports[`<Users /> should render a single user 1`] = `
         <li>
           <button
             class="mx_DevTools_button"
+            type="button"
           >
             <div
               class="mx_E2EIcon mx_E2EIcon_inline"
@@ -757,7 +766,9 @@ exports[`<Users /> should render a single user 1`] = `
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
   </div>
@@ -828,7 +839,9 @@ exports[`<Users /> should render a user list 1`] = `
   <div
     class="mx_Dialog_buttons"
   >
-    <button>
+    <button
+      type="button"
+    >
       Back
     </button>
   </div>

apps/web/test/unit-tests/components/views/dialogs/security/__snapshots__/ExportE2eKeysDialog-test.tsx.snap

@@ -92,7 +92,9 @@ exports[`ExportE2eKeysDialog renders 1`] = `
           type="submit"
           value="Export"
         />
-        <button>
+        <button
+          type="button"
+        >
           Cancel
         </button>
       </div>

apps/web/test/unit-tests/components/views/dialogs/security/__snapshots__/ImportE2eKeysDialog-test.tsx.snap

@@ -93,7 +93,9 @@ exports[`ImportE2eKeysDialog renders 1`] = `
           type="submit"
           value="Import"
         />
-        <button>
+        <button
+          type="button"
+        >
           Cancel
         </button>
       </div>