Enable oxlint restriction ruleset (#34307)

* Remove stale max-len disablements

* Remove stale camelCase & naming-convention disablements

* Remove stale ban-ts-comment disablements

* Remove stale no-var disablements

* Remove stale no-empty-property disablements

* Remove stale react rule disablements

* Remove stale no-constant-condition disablements

* Remove stale no-unused-vars disablements

* Remove stale disablements for disabled rules

* fixup camelcase

* Remove dead code

* Tidy code

* Tweak oxlint config

* Use oxlint to apply jsx/tsx extension consistently

* Fix import

* Fix imports

* Rename affected snapshots

* Update more imports

* Enable restriction ruleset

* Make code comply with new rules

* Make code comply with react/button-has-type

* Make code comply with typescript/non-nullable-type-assertion-style

* Comply with node/no-process-env

* Comply with unicorn/prefer-node-protocol

* Comply with unicorn/import-style

* Comply with unicorn/no-process-exit

* Comply with no-proto

* Comply with node/handle-callback-err

* Comply with import/no-commonjs

* Comply with node/no-path-concat

* Comply with unicorn/no-length-as-slice-end

* Comply with unicorn/no-document-cookie

* Comply with unicorn/prefer-module

* Comply with typescript/prefer-literal-enum-member

* Comply with jsx-a11y/anchor-ambiguous-text

* Tweak oxlint config

* Fix resolves

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

apps/web/test/unit-tests/components/views/messages/MImageReplyBody-test.tsx

@@ -227,7 +227,7 @@ describe("<MImageReplyBody />", () => {
     it("opens the image viewer with thumbnail geometry", async () => {
         const { container } = renderBase();
         await waitFor(() => expect(screen.getByRole("img", { name: "demo image" })).toBeInTheDocument());
-        const image = container.querySelector("img.mx_MImageBody_thumbnail") as HTMLImageElement;
+        const image = container.querySelector("img.mx_MImageBody_thumbnail")!;
         image.getBoundingClientRect = () => ({ width: 100, height: 80, x: 10, y: 20 }) as DOMRect;
         jest.spyOn(Modal, "createDialog").mockReturnValue({} as any);
 
@@ -257,7 +257,7 @@ describe("<MImageReplyBody />", () => {
     it("updates load dimensions and toggles hover/focus banner state", async () => {
         const { container, ref } = renderBase();
         await waitFor(() => expect(screen.getByRole("img", { name: "demo image" })).toBeInTheDocument());
-        const image = container.querySelector("img.mx_MImageBody_thumbnail") as HTMLImageElement;
+        const image = container.querySelector("img.mx_MImageBody_thumbnail")!;
         Object.defineProperty(image, "naturalWidth", { configurable: true, value: 640 });
         Object.defineProperty(image, "naturalHeight", { configurable: true, value: 480 });
 
@@ -466,7 +466,7 @@ describe("<MImageReplyBody />", () => {
             },
         });
         await waitFor(() => expect(container.querySelector("img[style*='display: none']")).not.toBeNull());
-        const image = container.querySelector("img[style*='display: none']") as HTMLImageElement;
+        const image = container.querySelector("img[style*='display: none']")!;
         Object.defineProperty(image, "naturalWidth", { configurable: true, value: 640 });
         Object.defineProperty(image, "naturalHeight", { configurable: true, value: 480 });
 

apps/web/test/unit-tests/components/views/messages/MessageEvent-test.tsx

@@ -10,8 +10,8 @@ import React from "react";
 import { fireEvent, render, type RenderResult } from "jest-matrix-react";
 import { type MatrixClient, type MatrixEvent, EventType, type Room, MsgType } from "matrix-js-sdk/src/matrix";
 import fetchMock from "@fetch-mock/jest";
-import fs from "fs";
-import path from "path";
+import fs from "node:fs";
+import path from "node:path";
 
 import SettingsStore from "../../../../../src/settings/SettingsStore";
 import { mkEvent, mkRoom, stubClient } from "../../../../test-utils";

apps/web/test/unit-tests/components/views/messages/__snapshots__/TextualBody-test.tsx.snap

@@ -541,6 +541,7 @@ exports[`<TextualBody /> renders formatted m.text correctly spoilers get injecte
   Hey 
   <button
     class="mx_EventTile_spoiler"
+    type="button"
   >
     <span
       class="mx_EventTile_spoiler_reason"