Enable oxlint restriction ruleset (#34307)

* Remove stale max-len disablements

* Remove stale camelCase & naming-convention disablements

* Remove stale ban-ts-comment disablements

* Remove stale no-var disablements

* Remove stale no-empty-property disablements

* Remove stale react rule disablements

* Remove stale no-constant-condition disablements

* Remove stale no-unused-vars disablements

* Remove stale disablements for disabled rules

* fixup camelcase

* Remove dead code

* Tidy code

* Tweak oxlint config

* Use oxlint to apply jsx/tsx extension consistently

* Fix import

* Fix imports

* Rename affected snapshots

* Update more imports

* Enable restriction ruleset

* Make code comply with new rules

* Make code comply with react/button-has-type

* Make code comply with typescript/non-nullable-type-assertion-style

* Comply with node/no-process-env

* Comply with unicorn/prefer-node-protocol

* Comply with unicorn/import-style

* Comply with unicorn/no-process-exit

* Comply with no-proto

* Comply with node/handle-callback-err

* Comply with import/no-commonjs

* Comply with node/no-path-concat

* Comply with unicorn/no-length-as-slice-end

* Comply with unicorn/no-document-cookie

* Comply with unicorn/prefer-module

* Comply with typescript/prefer-literal-enum-member

* Comply with jsx-a11y/anchor-ambiguous-text

* Tweak oxlint config

* Fix resolves

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

packages/shared-components/src/core/i18n/I18nApi.ts

@@ -53,7 +53,7 @@ export class I18nApi implements II18nApi {
     public translate(this: void, key: TranslationKey, variables: Variables | undefined, tags: Tags): React.ReactNode;
     public translate(this: void, key: TranslationKey, variables?: Variables, tags?: Tags): React.ReactNode | string {
         if (tags) return _t(key, variables, tags);
-        return _t(key, variables as Variables);
+        return _t(key, variables!);
     }
 
     public humanizeTime = (timeMillis: number): string => humanizeTime(timeMillis, this);

packages/shared-components/src/menus/UserMenu/UserMenu.tsx

@@ -143,7 +143,7 @@ export function UserMenuView({ vm, className }: UserMenuViewProps): JSX.Element
     } = useViewModel(vm);
     const { translate: _t } = useI18n();
     const trigger = (
-        <button className={styles.triggerButton} aria-label={_t("menus|user_menu|title")}>
+        <button className={styles.triggerButton} aria-label={_t("menus|user_menu|title")} type="button">
             <div className={styles.avatarWrapper}>
                 <Avatar id={userId} name={displayName} type="round" size="36px" src={avatarUrl} />
                 {userStatus && (

packages/shared-components/src/room/timeline/event-tile/EventTileView/ThreadSummary/ThreadSummaryView.tsx

@@ -169,6 +169,7 @@ export function ThreadSummaryView({
         .join(" ");
 
     return (
+        // oxlint-disable-next-line react/button-has-type
         <button {...props} type={type} className={buttonClassName} onClick={vm.onClick} aria-label={openThreadLabel}>
             <IndicatorIcon size="24px" indicator={notificationIndicator} className={styles.threadIcon}>
                 <ThreadsSolidIcon />

packages/shared-components/src/room/timeline/event-tile/UrlPreviewGroupView/LinkPreview/LinkPreview.tsx

@@ -178,6 +178,7 @@ export function LinkPreviewExpanded(preview: LinkPreviewProps): JSX.Element {
                     className={styles.preview}
                     onClick={createImageClickHandler(preview)}
                     aria-label={_t("timeline|url_preview|view_image")}
+                    type="button"
                 />
             );
         }

packages/shared-components/src/room/timeline/event-tile/UrlPreviewGroupView/LinkPreview/__snapshots__/LinkPreview.test.tsx.snap

@@ -72,6 +72,7 @@ exports[`LinkPreview > renders a preview 1`] = `
       aria-label="View image"
       class="LinkPreview-module_preview"
       style="background-image: url("/static/element.png");"
+      type="button"
     />
     <div
       class="LinkPreview-module_textContent"

packages/shared-components/src/room/timeline/event-tile/UrlPreviewGroupView/__snapshots__/UrlPreviewGroupView.test.tsx.snap

@@ -46,6 +46,7 @@ exports[`UrlPreviewGroupView > renders a single preview 1`] = `
           aria-label="View image"
           class="LinkPreview-module_preview"
           style="background-image: url("/static/element.png");"
+          type="button"
         />
         <div
           class="LinkPreview-module_textContent"
@@ -125,6 +126,7 @@ exports[`UrlPreviewGroupView > renders multiple previews 1`] = `
           aria-label="View image"
           class="LinkPreview-module_preview"
           style="background-image: url("/static/element.png");"
+          type="button"
         />
         <div
           class="LinkPreview-module_textContent"
@@ -281,6 +283,7 @@ exports[`UrlPreviewGroupView > renders multiple previews which are hidden 1`] =
           aria-label="View image"
           class="LinkPreview-module_preview"
           style="background-image: url("/static/element.png");"
+          type="button"
         />
         <div
           class="LinkPreview-module_textContent"
@@ -369,6 +372,7 @@ exports[`UrlPreviewGroupView > renders with compact density 1`] = `
           aria-label="View image"
           class="LinkPreview-module_preview"
           style="background-image: url("/static/element.png");"
+          type="button"
         />
         <div
           class="LinkPreview-module_textContent"