Merge pull request #28236 from element-hq/t3chguy/sonar-happy

2024-10-18 15:55:15 +01:00
parent d638d5d5fa 51c308f2ec
commit 4e93233a3d
18 changed files with 46 additions and 67 deletions
@@ -296,10 +296,10 @@ export class PosthogAnalytics {
                    // until the next time account data is refreshed and this function is called (most likely on next
                    // page load). This will happen pretty infrequently, so we can tolerate the possibility.
                    analyticsID = analyticsIdGenerator();
-                    await client.setAccountData(
-                        PosthogAnalytics.ANALYTICS_EVENT_TYPE,
-                        Object.assign({ id: analyticsID }, accountData),
-                    );
+                    await client.setAccountData(PosthogAnalytics.ANALYTICS_EVENT_TYPE, {
+                        id: analyticsID,
+                        ...accountData,
+                    });
                }
                if (this.posthog.get_distinct_id() === analyticsID) {
                    // No point identifying again