sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Phase 2 : Refactor TextualBody to MVVM and remove legacy component (#33165)

Browse Source 
* Refactor TextualBody to MVVM and remove legacy component

* Update snapshot + fix eslint warning

* update css to fix playwright tests failure

* return i18n into the MVVM

* Update snapshots

* Update tests to reflect the css changes

* Update snapshot

* Update css to correct letter-spacing

* Update css to fix playwright issues.

* Preserve inline emote sender rendering in TextualBodyView

* Update snapshot to reflect html change

* Update back to span instead of button, the default button css fails tests

* Extract TextualBodyFactory from MBodyFactory

* Update snapshot

* Update HTML snapshot to pass tests

* Update Snapshots

* Added several tests for coverage

* Remove double checks, merge function already checks.

* Remove unessecery comment

* revert to button

* Update snapshots because of the revert

* added Math.min() to simplify ternary expressions.

* Update playwright screenshots for accessibility

* Update playwright screenshots

* Update css to fix playwright fail

* Update screenshot + snapshots

* Add comments to props
This commit is contained in:
Zack
2026-04-28 07:07:19 +00:00
committed by GitHub
parent 7766ae92d7
commit 4e9655dc6b
42 changed files with 1061 additions and 555 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/playwright/e2e/editing/editing.spec.ts
+4 -4
View File
@@ -50,7 +50,7 @@ test.describe("Editing", () => {
const eventTile = page.locator(".mx_EventTile", { hasText: edited });
await expect(eventTile).toBeVisible();
// Click to display the message edit history dialog
await eventTile.getByText("(edited)").click();
await eventTile.getByRole("button", { name: /Edited at .*? Click to view edits\./ }).click();
};
const clickButtonViewSource = async (locator: Locator) => {
@@ -89,7 +89,7 @@ test.describe("Editing", () => {
await editLastMessage(page, "Massage");
// Assert that the edit label is visible
await expect(page.locator(".mx_EventTile_edited")).toBeVisible();
await expect(page.getByRole("button", { name: /Edited at .*? Click to view edits\./ })).toBeVisible();
await clickEditedMessage(page, "Massage");
@@ -213,7 +213,7 @@ test.describe("Editing", () => {
await editLastMessage(page, "Massage");
// Assert that the edit label is visible
await expect(page.locator(".mx_EventTile_edited")).toBeVisible();
await expect(page.getByRole("button", { name: /Edited at .*? Click to view edits\./ })).toBeVisible();
await clickEditedMessage(page, "Massage");
@@ -369,6 +369,6 @@ test.describe("Editing", () => {
// nevertheless, the event should be updated
await expect(messageTile.locator(".mx_EventTile_body")).toHaveText("Edited body");
await expect(messageTile.locator(".mx_EventTile_edited")).toBeVisible();
await expect(messageTile.getByRole("button", { name: /Edited at .*? Click to view edits\./ })).toBeVisible();
});
});