Switch ModalManager to the React 18 createRoot API (#28336)

* Remove boilerplate around dispatcher and settings watchers Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Move state update listeners from constructor to componentDidMount Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Switch ModalManager to the React 18 createRoot API Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2024-11-04 11:34:00 +00:00
parent 38e5eeea00
commit 502cc91dfe
9 changed files with 66 additions and 60 deletions
@@ -202,7 +202,7 @@ describe("<JoinRuleSettings />", () => {

                await flushPromises();

-                expect(within(dialog).getByText("Loading new room")).toBeInTheDocument();
+                await expect(within(dialog).findByText("Loading new room")).resolves.toBeInTheDocument();

                // "create" our new room, have it come thru sync
                client.getRoom.mockImplementation((id) => {
@@ -250,7 +250,7 @@ describe("<JoinRuleSettings />", () => {

                await flushPromises();

-                expect(within(dialog).getByText("Loading new room")).toBeInTheDocument();
+                await expect(within(dialog).findByText("Loading new room")).resolves.toBeInTheDocument();

                // "create" our new room, have it come thru sync
                client.getRoom.mockImplementation((id) => {
@@ -119,6 +119,7 @@ describe("<SessionManagerTab />", () => {
    const mockVerificationRequest = {
        cancel: jest.fn(),
        on: jest.fn(),
+        off: jest.fn(),
    } as unknown as VerificationRequest;

    const mockCrypto = mocked({