sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Don't clear filters on space change (#30903)

Browse Source
This commit is contained in:
David Langley
2025-09-30 09:53:48 +00:00
committed by GitHub
parent a9f4ccaa02
commit 7e48f2b6b6
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/viewmodels/roomlist/useFilteredRooms.tsx
-5
View File
@@ -15,8 +15,6 @@ import RoomListStoreV3, {
type RoomsResult, type RoomsResult,
} from "../../../stores/room-list-v3/RoomListStoreV3"; } from "../../../stores/room-list-v3/RoomListStoreV3";
import { useEventEmitter } from "../../../hooks/useEventEmitter"; import { useEventEmitter } from "../../../hooks/useEventEmitter";
import SpaceStore from "../../../stores/spaces/SpaceStore";
import { UPDATE_SELECTED_SPACE } from "../../../stores/spaces";
/** /**
* Provides information about a primary filter. * Provides information about a primary filter.
@@ -74,9 +72,6 @@ export function useFilteredRooms(): FilteredRooms {
setRoomsResult(newRooms); setRoomsResult(newRooms);
}, []); }, []);
// Reset filters when active space changes
useEventEmitter(SpaceStore.instance, UPDATE_SELECTED_SPACE, () => setPrimaryFilter(undefined));
const filterUndefined = (array: (FilterKey | undefined)[]): FilterKey[] => const filterUndefined = (array: (FilterKey | undefined)[]): FilterKey[] =>
array.filter((f) => f !== undefined) as FilterKey[]; array.filter((f) => f !== undefined) as FilterKey[];
test/unit-tests/components/viewmodels/roomlist/RoomListViewModel-test.tsx
+3 -3
View File
@@ -127,7 +127,7 @@ describe("RoomListViewModel", () => {
expect(vm.current.activePrimaryFilter).toEqual(vm.current.primaryFilters[i]); expect(vm.current.activePrimaryFilter).toEqual(vm.current.primaryFilters[i]);
}); });
it("should remove all filters when active space is changed", async () => { it("should not remove all filters when active space is changed", async () => {
mockAndCreateRooms(); mockAndCreateRooms();
const { result: vm } = renderHook(() => useRoomListViewModel()); const { result: vm } = renderHook(() => useRoomListViewModel());
@@ -141,8 +141,8 @@ describe("RoomListViewModel", () => {
// Simulate a space change // Simulate a space change
await act(() => SpaceStore.instance.emit(UPDATE_SELECTED_SPACE)); await act(() => SpaceStore.instance.emit(UPDATE_SELECTED_SPACE));
// Primary filer should have been unapplied // Primary filter should remain unchanged
expect(vm.current.activePrimaryFilter).toEqual(undefined); expect(vm.current.activePrimaryFilter?.name).toEqual("People");
}); });
}); });