sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Remove SpaceStore singleton (#34088)

Browse Source 
* Remove dead code

* Remove LegacyCallHandler singleton

Route via SDKContext to cut import cycles

* Remove SpaceStore singleton

Route via SDKContext to cut import cycles

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Iterate

* Post-merge fixup

* Iterate
This commit is contained in:
Michael Telatynski
2026-07-13 14:31:39 +00:00
committed by GitHub
parent 7206d887f9
commit 825fab6595
46 changed files with 466 additions and 403 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/test/unit-tests/utils/i18n-helpers-test.ts
+6 -4
View File
@@ -9,10 +9,10 @@ Please see LICENSE files in the repository root for full details.
import { Room } from "matrix-js-sdk/src/matrix";
import { mocked } from "jest-mock";
import SpaceStore from "../../../src/stores/spaces/SpaceStore";
import { stubClient } from "../../test-utils";
import { roomContextDetails } from "../../../src/utils/i18n-helpers";
import DMRoomMap from "../../../src/utils/DMRoomMap";
import { SDKContextClass } from "../../../src/contexts/SDKContextClass.ts";
describe("roomContextDetails", () => {
const client = stubClient();
@@ -30,21 +30,23 @@ describe("roomContextDetails", () => {
});
it("should return 1-parent variant", () => {
jest.spyOn(SpaceStore.instance, "getKnownParents").mockReturnValue(new Set([parent1.roomId]));
jest.spyOn(SDKContextClass.instance.spaceStore, "getKnownParents").mockReturnValue(new Set([parent1.roomId]));
const res = roomContextDetails(room);
expect(res!.details).toMatchInlineSnapshot(`"Alpha"`);
expect(res!.ariaLabel).toMatchInlineSnapshot(`"In Alpha."`);
});
it("should return 2-parent variant", () => {
jest.spyOn(SpaceStore.instance, "getKnownParents").mockReturnValue(new Set([parent2.roomId, parent3.roomId]));
jest.spyOn(SDKContextClass.instance.spaceStore, "getKnownParents").mockReturnValue(
new Set([parent2.roomId, parent3.roomId]),
);
const res = roomContextDetails(room);
expect(res!.details).toMatchInlineSnapshot(`"Beta and Charlie"`);
expect(res!.ariaLabel).toMatchInlineSnapshot(`"In spaces Beta and Charlie."`);
});
it("should return n-parent variant", () => {
jest.spyOn(SpaceStore.instance, "getKnownParents").mockReturnValue(
jest.spyOn(SDKContextClass.instance.spaceStore, "getKnownParents").mockReturnValue(
new Set([parent1.roomId, parent2.roomId, parent3.roomId]),
);
const res = roomContextDetails(room);