sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Make viewRoomByName dismiss toasts on each retry (#33542)

Browse Source 
Otherwise it can just race, as per comment
This commit is contained in:
David Baker
2026-05-20 14:26:08 +00:00
committed by GitHub
parent 223a861535
commit 90ba56c1ce
1 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/playwright/pages/ElementAppPage.ts
+24 -8
View File
@@ -100,15 +100,31 @@ export class ElementAppPage {
// otherwise we may race with page loading // otherwise we may race with page loading
await this.page.getByTestId("room-list").waitFor(); await this.page.getByTestId("room-list").waitFor();
await rejectToastIfExists(this.page, "Verify this device", { timeout: 50 }); const dismissToasts = async (): Promise<void> => {
const keyStorageToastRejected = await rejectToastIfExists(this.page, "Turn on key storage", { timeout: 50 }); await rejectToastIfExists(this.page, "Verify this device", { timeout: 50 });
if (keyStorageToastRejected) { const keyStorageToastRejected = await rejectToastIfExists(this.page, "Turn on key storage", {
await this.page.getByRole("button", { name: "Yes, dismiss" }).click(); timeout: 50,
} });
await rejectToastIfExists(this.page, "Notifications", { timeout: 50 }); if (keyStorageToastRejected) {
await this.page.getByRole("button", { name: "Yes, dismiss" }).click();
}
await rejectToastIfExists(this.page, "Notifications", { timeout: 50 });
};
// We get the room list by test-id which is a listbox and matching title=name await dismissToasts();
return this.page.getByTestId("room-list").locator(`[title="${name}"]`).first().click();
// We get the room list by test-id which is a listbox and matching title=name.
// Retry, closing toasts each time, as otherwise it can race and the toast can appear after we try to close them
const roomTile = this.page.getByTestId("room-list").locator(`[title="${name}"]`).first();
for (let attemptsLeft = 10; attemptsLeft > 0; attemptsLeft--) {
try {
await roomTile.click({ timeout: 500 });
return;
} catch (e) {
if (attemptsLeft === 1) throw e;
await dismissToasts();
}
}
} }
/** /**