sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Fix usages of ARIA tabpanel (#10628)

Browse Source 
* RovingTabIndex handle looping around start/end

* Make TabbedView expose aria tabpanel/tablist/tab roles

* Fix right panel being wrongly specified as aria tabs

Not all right panels map to the top right header buttons so we cannot describe it as a tabpanel relation

* tsc strict

* Update snapshots

* Fix ARIA AXE violation

* Update tests
This commit is contained in:
Michael Telatynski
2023-04-25 09:31:54 +01:00
committed by GitHub
parent 961b843662
commit a1a087f755
9 changed files with 153 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cypress/e2e/integration-manager/get-openid-token.spec.ts
+1 -1
View File
@@ -59,7 +59,7 @@ const INTEGRATION_MANAGER_HTML = `
`;
function openIntegrationManager() {
cy.findByRole("tab", { name: "Room info" }).click();
cy.findByRole("button", { name: "Room info" }).click();
cy.findByRole("button", { name: "Add widgets, bridges & bots" }).click();
}
cypress/e2e/integration-manager/kick.spec.ts
+1 -1
View File
@@ -62,7 +62,7 @@ const INTEGRATION_MANAGER_HTML = `
`;
function openIntegrationManager() {
cy.findByRole("tab", { name: "Room info" }).click();
cy.findByRole("button", { name: "Room info" }).click();
cy.findByRole("button", { name: "Add widgets, bridges & bots" }).click();
}