React error/warning cleanup

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2019-10-08 12:10:37 +01:00
parent 15e7559d5b
commit a782baf510
10 changed files with 62 additions and 85 deletions
@@ -30,7 +30,9 @@ export default class CookieBar extends React.Component {
        super();
    }

-    onUsageDataClicked() {
+    onUsageDataClicked(e) {
+        e.stopPropagation();
+        e.preventDefault();
        Analytics.showDetailsModal();
    }

@@ -61,7 +63,6 @@ export default class CookieBar extends React.Component {
                        {
                            'UsageDataLink': (sub) => <a
                                className="mx_MatrixToolbar_link"
-                                href="javascript:;"
                                onClick={this.onUsageDataClicked}
                            >
                                { sub }
@@ -83,7 +84,6 @@ export default class CookieBar extends React.Component {
                        {
                            'UsageDataLink': (sub) => <a
                                className="mx_MatrixToolbar_link"
-                                href="javascript:;"
                                onClick={this.onUsageDataClicked}
                            >
                                { sub }