Tweak oxlint config & delint our code (#34301)

* Remove stale max-len disablements

* Remove stale camelCase & naming-convention disablements

* Remove stale ban-ts-comment disablements

* Remove stale no-var disablements

* Remove stale no-empty-property disablements

* Remove stale react rule disablements

* Remove stale no-constant-condition disablements

* Remove stale no-unused-vars disablements

* Remove stale disablements for disabled rules

* fixup camelcase

* Remove dead code

* Tidy code

* Tweak oxlint config

apps/web/playwright/e2e/forgot-password/forgot-password.spec.ts

@@ -14,7 +14,6 @@ import { isDendrite } from "../../plugins/homeserver/dendrite";
 const email = "user@nowhere.dummy";
 
 const test = base.extend({
-    // eslint-disable-next-line no-empty-pattern
     credentials: async ({}, use, testInfo) => {
         await use({
             username: `user_${testInfo.testId}`,

apps/web/playwright/element-web-test.ts

@@ -93,7 +93,6 @@ export const test = base.extend<TestFixtures>({
         await bot.onTestFinished(testInfo);
     },
 
-    // eslint-disable-next-line no-empty-pattern
     webserver: async ({}, use) => {
         const webserver = new Webserver();
         await use(webserver);

apps/web/playwright/plugins/homeserver/synapse/legacyOAuthHomeserver.ts

@@ -13,7 +13,6 @@ import { type Fixtures } from "../../../element-web-test.ts";
 
 export const legacyOAuthHomeserver: Fixtures = {
     oAuthServer: [
-        // eslint-disable-next-line no-empty-pattern
         async ({}, use) => {
             const server = new OAuthServer();
             await use(server);