Remove more usages of singleton store getter in favour of contexts (#34099)

* Expose SDKContextClass via window for debugging

* Remove stores from window if they are exposed via sdkContext

* Avoid usages of global store instance where React context is accessible

* Remove more usages of singleton store getter in favour of contexts

* Remove more usages of singleton store getter in favour of contexts

* Fix tests by adding SDKContext.Provider

* Fix tests by adding SDKContext.Provider

* Fix tests by adding SDKContext.Provider

* Fix tests by adding SDKContext.Provider

* Fix tests

* Fix tests

* Fix tests

* Iterate

* Fix bad merge

* Iterate

* Fix tests

* Iterate

* Iterate

* Iterate

* Iterate

* Iterate

* Improve coverage

* Improve coverage

apps/web/test/unit-tests/components/views/voip/LegacyCallView-test.tsx

@@ -27,8 +27,6 @@ describe("LegacyCallView", () => {
         document.fullscreenElement = element;
         document.exitFullscreen = jest.fn();
 
-        stubClient();
-
         const call = {
             on: jest.fn(),
             removeListener: jest.fn(),
@@ -50,8 +48,7 @@ describe("LegacyCallView", () => {
     });
 
     it("should show/hide the sidebar based on the sidebarShown prop", async () => {
-        stubClient();
-
+        const cli = stubClient();
         const call = {
             roomId: "test-room",
             on: jest.fn(),
@@ -93,8 +90,7 @@ describe("LegacyCallView", () => {
     });
 
     it("should not show the sidebar button in picture-in-picture mode", async () => {
-        stubClient();
-
+        const cli = stubClient();
         const call = {
             on: jest.fn(),
             removeListener: jest.fn(),

apps/web/test/unit-tests/components/views/voip/LegacyCallViewForRoom-test.tsx

@@ -16,7 +16,6 @@ import { clientAndSDKContextRenderOptions, mkStubRoom, stubClient } from "../../
 import DMRoomMap from "../../../../../src/utils/DMRoomMap";
 import { MatrixClientPeg } from "../../../../../src/MatrixClientPeg";
 import LegacyCallHandler from "../../../../../src/LegacyCallHandler";
-import { SDKContext } from "../../../../../src/contexts/SDKContext";
 import { TestSDKContext } from "../../../TestSDKContext.ts";
 
 jest.mock("../../../../../src/components/views/voip/LegacyCallView", () => jest.fn(() => "LegacyCallView"));
@@ -93,9 +92,10 @@ describe("LegacyCallViewForRoom", () => {
         jest.spyOn(sdkContext.resizeNotifier, "stopResizing");
         jest.spyOn(sdkContext.resizeNotifier, "notifyTimelineHeightChanged");
 
-        const { container } = render(<LegacyCallViewForRoom roomId={call.roomId} />, {
-            wrapper: ({ children }) => <SDKContext.Provider value={sdkContext}>{children}</SDKContext.Provider>,
-        });
+        const { container } = render(
+            <LegacyCallViewForRoom roomId={call.roomId} />,
+            clientAndSDKContextRenderOptions(sdkContext.client!, sdkContext),
+        );
 
         const resizer = container.querySelector(".mx_LegacyCallViewForRoom_ResizeHandle");
         await waitFor(() => {