sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Enable more oxlint rules (#34189)

Browse Source 
* Fix type imports

* Fix jsdoc

* Fixup types

* Fix stray awaits on non-thenables

* Fixup imports

* Fix splats

* Fix this-context on callbacks

* Memoise react contexts

* Prefer find/flatMap

* Make oxlint happier about our React keys

* Avoid unsafe default function params

* Fixup jsdoc

* Fixup contexts

* Switch from eslint to oxlint

* Some oxlint-related tweaks

* Iterate

* Partial revert to defer some changes and shrink diff

* Iterate

* Add eslint-plugin-element-call and enable the copyright rule

* Set strictStorePkgContentCheck

* Iterate

* Enable forwardRef oxlint rule

* Enable no-unused-vars oxlint rule

* Enable no-implied-eval oxlint rule

* Enable no-duplicate-type-constituents oxlint rule

* Enable explicit-length-check oxlint rule

* Enable prefer-number-properties oxlint rule

* Enable no-callback-in-promise oxlint rule

* Enable no-require-imports oxlint rule

* Remove disablement of most unicorn oxlint rules

* Enable no-conditional-tests oxlint rule

* Enable promise-valid-params oxlint rule

* Enable require-unicode-regexp oxlint rule

* Remove max-len comments as we use oxfmt for formatting

* Enable majority of oxlint `suspicious` rules

* Iterate

* Fix oxlint type-aware lint running without dependencies built
This commit is contained in:
Michael Telatynski
2026-07-29 08:26:07 +00:00
committed by GitHub
parent e8848e4746
commit bbec915fb0
178 changed files with 405 additions and 403 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/desktop/src/vectormenu.test.ts
+6 -8
View File
@@ -42,12 +42,10 @@ describe("buildMenuTemplate", () => {
({ buildMenuTemplate } = await import("./vectormenu.js"));
});
if (platform === "darwin") {
it("should have an app-named item first", () => {
const menu = buildMenuTemplate();
expect(menu.items[0].label).toBe("ChatApp");
});
}
it.runIf(platform === "darwin")("should have an app-named item first", () => {
const menu = buildMenuTemplate();
expect(menu.items[0].label).toBe("ChatApp");
});
it("should include expected `help` menu", () => {
const menu = buildMenuTemplate();
@@ -55,8 +53,8 @@ describe("buildMenuTemplate", () => {
const helpMenu = menu.items.at(-1)!;
expect(helpMenu.label).toBe("common|help");
const helpSubmenu = helpMenu.submenu as unknown as MenuItemConstructorOptions[];
expect(helpSubmenu[0]!.label).toBe("common|brand_help");
helpSubmenu[0]!.click!(menu.items.at(-1)!, undefined, new Event("click") as KeyboardEvent);
expect(helpSubmenu[0].label).toBe("common|brand_help");
helpSubmenu[0].click!(menu.items.at(-1)!, undefined, new Event("click") as KeyboardEvent);
expect(shell.openExternal).toHaveBeenCalledWith("https://i.need.help");
});
});