Enable more oxlint rules (#34189)

* Fix type imports

* Fix jsdoc

* Fixup types

* Fix stray awaits on non-thenables

* Fixup imports

* Fix splats

* Fix this-context on callbacks

* Memoise react contexts

* Prefer find/flatMap

* Make oxlint happier about our React keys

* Avoid unsafe default function params

* Fixup jsdoc

* Fixup contexts

* Switch from eslint to oxlint

* Some oxlint-related tweaks

* Iterate

* Partial revert to defer some changes and shrink diff

* Iterate

* Add eslint-plugin-element-call and enable the copyright rule

* Set strictStorePkgContentCheck

* Iterate

* Enable forwardRef oxlint rule

* Enable no-unused-vars oxlint rule

* Enable no-implied-eval oxlint rule

* Enable no-duplicate-type-constituents oxlint rule

* Enable explicit-length-check oxlint rule

* Enable prefer-number-properties oxlint rule

* Enable no-callback-in-promise oxlint rule

* Enable no-require-imports oxlint rule

* Remove disablement of most unicorn oxlint rules

* Enable no-conditional-tests oxlint rule

* Enable promise-valid-params oxlint rule

* Enable require-unicode-regexp oxlint rule

* Remove max-len comments as we use oxfmt for formatting

* Enable majority of oxlint `suspicious` rules

* Iterate

* Fix oxlint type-aware lint running without dependencies built

apps/web/playwright/e2e/read-receipts/index.ts

@@ -609,7 +609,7 @@ class Helpers {
         const roomListContainer = this.page.getByTestId("room-list");
         const roomTiles = roomListContainer.getByRole("option");
         for (const [i, room] of rooms.entries()) {
-            await expect(roomTiles.nth(i)).toHaveAccessibleName(new RegExp(`${room.name}`));
+            await expect(roomTiles.nth(i)).toHaveAccessibleName(new RegExp(room.name));
         }
     }
 }

apps/web/playwright/e2e/read-receipts/read-receipts.spec.ts

@@ -120,11 +120,11 @@ test.describe("Read receipts", { tag: "@mergequeue" }, () => {
         await sendUnthreadedReadReceipt(app, main2);
 
         // (So the room has no unreads)
-        await expect(page.getByLabel(`${otherRoomName}`)).toBeVisible();
+        await expect(page.getByLabel(otherRoomName)).toBeVisible();
 
         // And we persuade the app to persist its state to indexeddb by reloading and waiting
         await page.reload();
-        await expect(page.getByLabel(`${selectedRoomName}`)).toBeVisible();
+        await expect(page.getByLabel(selectedRoomName)).toBeVisible();
 
         // And we reload again, fetching the persisted state FROM indexeddb
         await page.reload();
@@ -132,7 +132,7 @@ test.describe("Read receipts", { tag: "@mergequeue" }, () => {
         // Then the room is read, because the persisted state correctly remembers both
         // receipts. (In #24629, the unthreaded receipt overwrote the main thread one,
         // meaning that the room still said it had unread messages.)
-        await expect(page.getByLabel(`${otherRoomName}`)).toBeVisible();
+        await expect(page.getByLabel(otherRoomName)).toBeVisible();
         await expect(page.getByLabel(`${otherRoomName} Unread messages.`)).not.toBeVisible();
     });
 
@@ -172,7 +172,7 @@ test.describe("Read receipts", { tag: "@mergequeue" }, () => {
         await sendThreadedReadReceipt(app, main3);
 
         // Then the room has no unreads
-        await expect(page.getByLabel(`${otherRoomName}`)).toBeVisible();
+        await expect(page.getByLabel(otherRoomName)).toBeVisible();
     });
 
     test("Recognises unread messages on other thread after receiving a receipt for earlier ones", async ({
@@ -210,7 +210,7 @@ test.describe("Read receipts", { tag: "@mergequeue" }, () => {
         await sendThreadedReadReceipt(app, thread1b, main1);
 
         // Then the room has no unreads
-        await expect(page.getByLabel(`${otherRoomName}`)).toBeVisible();
+        await expect(page.getByLabel(otherRoomName)).toBeVisible();
         await util.goTo({ name: otherRoomName, roomId: otherRoomId });
         await util.assertReadThread("Message 1");
     });
@@ -235,7 +235,7 @@ test.describe("Read receipts", { tag: "@mergequeue" }, () => {
         // thread. The one in main is read because the unthreaded
         // receipt is for a later event. The room should therefore be
         // read, and the thread unread.
-        await expect(page.getByLabel(`${otherRoomName}`)).toBeVisible();
+        await expect(page.getByLabel(otherRoomName)).toBeVisible();
         await util.goTo({ name: otherRoomName, roomId: otherRoomId });
         await util.assertUnreadThread("Message 1");
     });