Enable more oxlint rules (#34189)

* Fix type imports

* Fix jsdoc

* Fixup types

* Fix stray awaits on non-thenables

* Fixup imports

* Fix splats

* Fix this-context on callbacks

* Memoise react contexts

* Prefer find/flatMap

* Make oxlint happier about our React keys

* Avoid unsafe default function params

* Fixup jsdoc

* Fixup contexts

* Switch from eslint to oxlint

* Some oxlint-related tweaks

* Iterate

* Partial revert to defer some changes and shrink diff

* Iterate

* Add eslint-plugin-element-call and enable the copyright rule

* Set strictStorePkgContentCheck

* Iterate

* Enable forwardRef oxlint rule

* Enable no-unused-vars oxlint rule

* Enable no-implied-eval oxlint rule

* Enable no-duplicate-type-constituents oxlint rule

* Enable explicit-length-check oxlint rule

* Enable prefer-number-properties oxlint rule

* Enable no-callback-in-promise oxlint rule

* Enable no-require-imports oxlint rule

* Remove disablement of most unicorn oxlint rules

* Enable no-conditional-tests oxlint rule

* Enable promise-valid-params oxlint rule

* Enable require-unicode-regexp oxlint rule

* Remove max-len comments as we use oxfmt for formatting

* Enable majority of oxlint `suspicious` rules

* Iterate

* Fix oxlint type-aware lint running without dependencies built

apps/web/test/unit-tests/components/views/dialogs/AskInviteAnywayDialog-test.tsx

@@ -16,9 +16,9 @@ import AskInviteAnywayDialog, {
 import SettingsStore from "../../../../../src/settings/SettingsStore";
 
 describe("AskInviteaAnywayDialog", () => {
-    const onFinished: jest.Mock<any, any> = jest.fn();
-    const onGiveUp: jest.Mock<any, any> = jest.fn();
-    const onInviteAnyways: jest.Mock<any, any> = jest.fn();
+    const onFinished = jest.fn();
+    const onGiveUp = jest.fn();
+    const onInviteAnyways = jest.fn();
 
     function renderComponent(props: Partial<AskInviteAnywayDialogProps> = {}): RenderResult {
         return render(

apps/web/test/unit-tests/components/views/dialogs/BugReportDialog-test.tsx

@@ -22,7 +22,7 @@ import { BugReportEndpointURLLocal } from "../../../../../src/IConfigOptions";
 const BUG_REPORT_URL = "https://example.org/submit";
 
 describe("BugReportDialog", () => {
-    const onFinished: jest.Mock<any, any> = jest.fn();
+    const onFinished = jest.fn();
 
     function renderComponent(props: Partial<BugReportDialogProps> = {}): RenderResult {
         return render(<BugReportDialog onFinished={onFinished} />);

apps/web/test/unit-tests/components/views/dialogs/ConfirmRejectInviteDialog-test.tsx

@@ -13,7 +13,7 @@ import SdkConfig from "../../../../../src/SdkConfig";
 import { DeclineAndBlockInviteDialog } from "../../../../../src/components/views/dialogs/DeclineAndBlockInviteDialog";
 
 describe("ConfirmRejectInviteDialog", () => {
-    const onFinished: jest.Mock<any, any> = jest.fn();
+    const onFinished = jest.fn();
 
     const MY_ROOM_NAME = "foo";
 

apps/web/test/unit-tests/components/views/dialogs/IncomingSasDialog-test.tsx

@@ -63,7 +63,7 @@ function makeMockSasCallbacks(): ShowSasCallbacks {
     const unicorn: EmojiMapping = ["🦄", "unicorn"];
     return {
         sas: {
-            emoji: new Array<EmojiMapping>(7).fill(unicorn),
+            emoji: Array.from<EmojiMapping>({ length: 7 }).map(() => unicorn),
         },
         cancel: jest.fn(),
         confirm: jest.fn(),

apps/web/test/unit-tests/components/views/dialogs/ReportRoomDialog-test.tsx

@@ -17,8 +17,8 @@ const ROOM_ID = "!foo:bar";
 const REASON = "This room is bad!";
 
 describe("ReportRoomDialog", () => {
-    const onFinished: jest.Mock<any, any> = jest.fn();
-    const reportRoom: jest.Mock<any, any> = jest.fn();
+    const onFinished: jest.Mock = jest.fn();
+    const reportRoom: jest.Mock = jest.fn();
     beforeEach(() => {
         jest.resetAllMocks();
         const client = stubClient();

apps/web/test/unit-tests/components/views/elements/SyntaxHighlight-test.tsx

@@ -22,6 +22,7 @@ describe("<SyntaxHighlight />", () => {
     it.each(["json", "javascript", "css"])("uses the provided language", async (lang) => {
         const mock = jest.spyOn(hljs, "highlight");
 
+        // oxlint-disable-next-line react/jsx-no-comment-textnodes
         const { container } = render(<SyntaxHighlight language={lang}>// Hello, World</SyntaxHighlight>);
         await waitFor(() => expect(container.querySelector(`.language-${lang}`)).toBeTruthy());
 

apps/web/test/unit-tests/components/views/messages/MLocationBody-test.tsx

@@ -70,7 +70,7 @@ describe("MLocationBody", () => {
         });
 
         describe("with error", () => {
-            let sdkConfigSpy: jest.SpyInstance<any>;
+            let sdkConfigSpy: jest.SpyInstance;
 
             beforeEach(() => {
                 // eat expected errors to keep console clean

apps/web/test/unit-tests/components/views/right_panel/VerificationPanel-test.tsx

@@ -206,7 +206,7 @@ function makeMockSasCallbacks(): ShowSasCallbacks {
     const unicorn: EmojiMapping = ["🦄", "unicorn"];
     return {
         sas: {
-            emoji: new Array<EmojiMapping>(7).fill(unicorn),
+            emoji: Array.from<EmojiMapping>({ length: 7 }).map(() => unicorn),
         },
         cancel: jest.fn(),
         confirm: jest.fn(),