Fix platform settings race condition and make auto-launch tri-state (#30977)

* Fix race condition with platform settings not being read correctly Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Allow Desktop app to be auto-started minimised or focused Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * i18n Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Use onChange prop Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update res/css/views/elements/_SettingsDropdown.pcss Co-authored-by: Florian Duros <florianduros@element.io> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Florian Duros <florianduros@element.io>
2025-10-09 13:20:53 +00:00
parent 3098eba4f2
commit bc7b50f97c
14 changed files with 253 additions and 55 deletions
@@ -0,0 +1,37 @@
+/*
+Copyright 2025 New Vector Ltd.
+
+SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
+Please see LICENSE files in the repository root for full details.
+*/
+
+import React from "react";
+import { render, screen } from "jest-matrix-react";
+
+import { SettingLevel } from "../../../../../src/settings/SettingLevel.ts";
+import SettingsDropdown from "../../../../../src/components/views/elements/SettingsDropdown.tsx";
+
+describe("<SettingsDropdown />", () => {
+    it("should render a disabled setting", async () => {
+        const { asFragment } = render(
+            <SettingsDropdown settingKey="Electron.autoLaunch" level={SettingLevel.PLATFORM} />,
+        );
+        expect(asFragment()).toMatchSnapshot();
+
+        const trigger = screen.getByRole("button");
+        expect(trigger).toHaveTextContent("No");
+        expect(trigger).toHaveAttribute("aria-disabled", "true");
+    });
+
+    it("should not render a disabled setting if hideIfCannotSet=true", async () => {
+        const { container } = render(
+            <SettingsDropdown settingKey="Electron.autoLaunch" level={SettingLevel.PLATFORM} hideIfCannotSet />,
+        );
+        expect(container).toBeEmptyDOMElement();
+    });
+
+    it("should not render a non-options setting", async () => {
+        const { container } = render(<SettingsDropdown settingKey="systemFont" level={SettingLevel.DEVICE} />);
+        expect(container).toBeEmptyDOMElement();
+    });
+});