sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Tidy build desktop macos workflow (#32949)

Browse Source
This commit is contained in:
Michael Telatynski
2026-03-27 20:06:35 +00:00
committed by GitHub
parent e8701f5a06
commit e10109ae0b
1 changed files with 10 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/build_desktop_macos.yaml
+10 -21
View File
@@ -128,22 +128,21 @@ jobs:
working-directory: apps/desktop working-directory: apps/desktop
run: pnpm run build:native:universal run: pnpm run build:native:universal
# We split these because electron-builder gets upset if we set CSC_LINK even to an empty string - name: "Build App"
- name: "[Signed] Build App"
if: inputs.sign != ''
working-directory: apps/desktop working-directory: apps/desktop
run: | run: pnpm run build:universal --publish never -m ${TARGETS}
pnpm run build:universal --publish never -m ${TARGETS}
env: env:
APPLE_TEAM_ID: ${{ vars.APPLE_TEAM_ID }} # Code signing parameters
APPLE_ID: ${{ secrets.APPLE_ID }} CSC_IDENTITY_AUTO_DISCOVERY: ${{ inputs.sign != '' }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} APPLE_TEAM_ID: ${{ case(inputs.sign != '', vars.APPLE_TEAM_ID, '') }}
CSC_KEY_PASSWORD: ${{ secrets.APPLE_CSC_KEY_PASSWORD }} APPLE_ID: ${{ case(inputs.sign != '', secrets.APPLE_ID, '') }}
CSC_LINK: ${{ secrets.APPLE_CSC_LINK }} APPLE_APP_SPECIFIC_PASSWORD: ${{ case(inputs.sign != '', secrets.APPLE_ID_PASSWORD, '') }}
CSC_KEY_PASSWORD: ${{ case(inputs.sign != '', secrets.APPLE_CSC_KEY_PASSWORD, '') }}
CSC_LINK: ${{ case(inputs.sign != '', secrets.APPLE_CSC_LINK, '') }}
VARIANT_PATH: variant.json VARIANT_PATH: variant.json
TARGETS: ${{ inputs.targets }}
# Only set for Nightly builds # Only set for Nightly builds
VERSION: ${{ inputs.version }} VERSION: ${{ inputs.version }}
TARGETS: ${{ inputs.targets }}
- name: Check app was signed & notarised successfully - name: Check app was signed & notarised successfully
if: inputs.sign != '' if: inputs.sign != ''
@@ -154,16 +153,6 @@ jobs:
spctl -a -vvv -t install /Volumes/Element/*.app spctl -a -vvv -t install /Volumes/Element/*.app
hdiutil detach /Volumes/Element hdiutil detach /Volumes/Element
- name: "[Unsigned] Build App"
if: inputs.sign == ''
working-directory: apps/desktop
run: |
pnpm run build:universal --publish never -m ${TARGETS}
env:
CSC_IDENTITY_AUTO_DISCOVERY: false
VARIANT_PATH: variant.json
TARGETS: ${{ inputs.targets }}
- name: Generate releases.json - name: Generate releases.json
if: inputs.base-url if: inputs.base-url
working-directory: apps/desktop working-directory: apps/desktop