Conform more code to strict null checking (#10169)

* Conform more code to strict null checking

* delint

* Iterate

* delint

* Fix bad test

test/stores/SpaceStore-test.ts

@@ -800,7 +800,7 @@ describe("SpaceStore", () => {
                     testUtils.mockStateEventImplementation([childEvent]),
                 );
 
-                client.emit(RoomStateEvent.Events, childEvent, spaceRoom.currentState, undefined);
+                client.emit(RoomStateEvent.Events, childEvent, spaceRoom.currentState, null);
             };
 
             const addMember = (spaceId: string, user: RoomMember) => {
@@ -964,7 +964,7 @@ describe("SpaceStore", () => {
                 }
             });
 
-            client.emit(RoomStateEvent.Members, event, null, null);
+            client.emit(RoomStateEvent.Members, event, space.currentState, dm1Partner);
             return deferred.resolve(true) as unknown as Promise<boolean>;
         });
 
@@ -1279,7 +1279,7 @@ describe("SpaceStore", () => {
             user: dm1Partner.userId,
             room: space1,
         });
-        client.emit(RoomStateEvent.Members, memberEvent, undefined, undefined);
+        client.emit(RoomStateEvent.Members, memberEvent, rootSpace.currentState, dm1Partner);
         jest.runOnlyPendingTimers();
         expect(SpaceStore.instance.getSpaceFilteredUserIds(space1).has(dm1Partner.userId)).toBeTruthy();
         const dm1Room = mkRoom(dm1);

test/stores/VoiceRecordingStore-test.ts

@@ -21,7 +21,7 @@ import { MatrixClientPeg } from "../../src/MatrixClientPeg";
 import { flushPromises } from "../test-utils";
 import { VoiceMessageRecording } from "../../src/audio/VoiceMessageRecording";
 
-const stubClient = {} as undefined as MatrixClient;
+const stubClient = {} as unknown as MatrixClient;
 jest.spyOn(MatrixClientPeg, "get").mockReturnValue(stubClient);
 
 describe("VoiceRecordingStore", () => {

test/stores/room-list/RoomListStore-test.ts

@@ -216,7 +216,7 @@ describe("RoomListStore", () => {
 
         // But when we update the feature flag
         featureFlagValue = true;
-        watchCallback(
+        watchCallback!(
             "feature_dynamic_room_predecessors",
             "",
             SettingLevel.DEFAULT,

test/stores/room-list/algorithms/RecentAlgorithm-test.ts

@@ -68,6 +68,7 @@ describe("RecentAlgorithm", () => {
 
         it("returns a fake ts for rooms without a timeline", () => {
             const room = mkRoom(cli, "!new:example.org");
+            // @ts-ignore
             room.timeline = undefined;
             expect(algorithm.getLastTs(room, "@john:matrix.org")).toBe(Number.MAX_SAFE_INTEGER);
         });