sorb/ThreadNet-Web
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Fix flake in room-security-tab (#33897)

Browse Source 
* Fix flake in room-security-tab

Wait for the power level change before trying to test.

* lint
This commit is contained in:
Will Hunt
2026-06-19 14:22:27 +00:00
committed by GitHub
parent 171164f324
commit fab71c80ed
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/playwright/e2e/settings/room-settings/room-security-tab.spec.ts
+11 -3
View File
@@ -24,7 +24,7 @@ test.describe("Roles & Permissions room settings tab", () => {
power_level_content_override: { power_level_content_override: {
events: { events: {
// Set the join rules as lower than the history vis to test an edge case. // Set the join rules as lower than the history vis to test an edge case.
["m.room.join_rules"]: 80, ["m.room.join_rules"]: 50,
["m.room.history_visibility"]: 100, ["m.room.history_visibility"]: 100,
}, },
}, },
@@ -99,14 +99,22 @@ test.describe("Roles & Permissions room settings tab", () => {
const ourComboBox = settings.getByRole("combobox", { name: user.userId }); const ourComboBox = settings.getByRole("combobox", { name: user.userId });
await ourComboBox.selectOption("Custom level"); await ourComboBox.selectOption("Custom level");
const ourPl = settings.getByRole("spinbutton", { name: user.userId }); const ourPl = settings.getByRole("spinbutton", { name: user.userId });
await ourPl.fill("80"); await ourPl.fill("50");
await page.keyboard.press("Tab"); // Shows a warning on await page.keyboard.press("Tab"); // Shows a warning on
// Accept the de-op // Accept the de-op
await page.getByRole("button", { name: "Continue" }).click(); await page.getByRole("button", { name: "Continue" }).click();
await settings.getByRole("button", { name: "Apply", disabled: false }).click(); await settings.getByRole("button", { name: "Apply", disabled: false }).click();
await app.settings.switchTab("Security & Privacy"); // Close and await power level
await app.settings.closeDialog();
const timeline = page.getByTestId("timeline");
await timeline.getByRole("button", { name: "expand" }).click();
await expect(
timeline.getByText("Alice changed the power level of Alice from Admin to Moderator."),
).toBeInViewport();
settings = await app.settings.openRoomSettings("Security & Privacy");
await settingsGroupAccess.getByText("Invite only").click(); await settingsGroupAccess.getByText("Invite only").click();
// Element should have automatically set the room to "sharing" history visibility // Element should have automatically set the room to "sharing" history visibility