rename EditableText's placeHolder parameter to be 'label' to avoid colliding with the HTML5 placeholder parameter

This commit is contained in:
Matthew Hodgson
2015-07-20 20:11:33 -07:00
parent e0673eee29
commit fe71f69f0a
8 changed files with 60 additions and 16 deletions
+4 -1
View File
@@ -22,6 +22,7 @@ module.exports = {
propTypes: {
onValueChanged: React.PropTypes.func,
initialValue: React.PropTypes.string,
label: React.PropTypes.string,
placeHolder: React.PropTypes.string,
},
@@ -34,7 +35,8 @@ module.exports = {
return {
onValueChanged: function() {},
initialValue: '',
placeHolder: 'Click to set',
label: 'Click to set',
placeholder: '',
};
},
@@ -77,6 +79,7 @@ module.exports = {
this.setState({
phase: this.Phases.Display,
});
this.onValueChanged(false);
},
onValueChanged: function(shouldSubmit) {