Michael Telatynski and GitHub
4aa1a3549e
Enable oxlint restriction ruleset ( #34307 )
...
* Remove stale max-len disablements
* Remove stale camelCase & naming-convention disablements
* Remove stale ban-ts-comment disablements
* Remove stale no-var disablements
* Remove stale no-empty-property disablements
* Remove stale react rule disablements
* Remove stale no-constant-condition disablements
* Remove stale no-unused-vars disablements
* Remove stale disablements for disabled rules
* fixup camelcase
* Remove dead code
* Tidy code
* Tweak oxlint config
* Use oxlint to apply jsx/tsx extension consistently
* Fix import
* Fix imports
* Rename affected snapshots
* Update more imports
* Enable restriction ruleset
* Make code comply with new rules
* Make code comply with react/button-has-type
* Make code comply with typescript/non-nullable-type-assertion-style
* Comply with node/no-process-env
* Comply with unicorn/prefer-node-protocol
* Comply with unicorn/import-style
* Comply with unicorn/no-process-exit
* Comply with no-proto
* Comply with node/handle-callback-err
* Comply with import/no-commonjs
* Comply with node/no-path-concat
* Comply with unicorn/no-length-as-slice-end
* Comply with unicorn/no-document-cookie
* Comply with unicorn/prefer-module
* Comply with typescript/prefer-literal-enum-member
* Comply with jsx-a11y/anchor-ambiguous-text
* Tweak oxlint config
* Fix resolves
* Iterate
* Iterate
* Iterate
* Iterate
* Iterate
* Iterate
* Iterate
2026-08-04 09:15:07 +00:00
Michael Telatynski and GitHub
bbec915fb0
Enable more oxlint rules ( #34189 )
...
* Fix type imports
* Fix jsdoc
* Fixup types
* Fix stray awaits on non-thenables
* Fixup imports
* Fix splats
* Fix this-context on callbacks
* Memoise react contexts
* Prefer find/flatMap
* Make oxlint happier about our React keys
* Avoid unsafe default function params
* Fixup jsdoc
* Fixup contexts
* Switch from eslint to oxlint
* Some oxlint-related tweaks
* Iterate
* Partial revert to defer some changes and shrink diff
* Iterate
* Add eslint-plugin-element-call and enable the copyright rule
* Set strictStorePkgContentCheck
* Iterate
* Enable forwardRef oxlint rule
* Enable no-unused-vars oxlint rule
* Enable no-implied-eval oxlint rule
* Enable no-duplicate-type-constituents oxlint rule
* Enable explicit-length-check oxlint rule
* Enable prefer-number-properties oxlint rule
* Enable no-callback-in-promise oxlint rule
* Enable no-require-imports oxlint rule
* Remove disablement of most unicorn oxlint rules
* Enable no-conditional-tests oxlint rule
* Enable promise-valid-params oxlint rule
* Enable require-unicode-regexp oxlint rule
* Remove max-len comments as we use oxfmt for formatting
* Enable majority of oxlint `suspicious` rules
* Iterate
* Fix oxlint type-aware lint running without dependencies built
2026-07-29 08:26:07 +00:00
Michael Telatynski and GitHub
b51c5ed8a7
Tweak oxlint config & delint our code ( #34301 )
...
* Remove stale max-len disablements
* Remove stale camelCase & naming-convention disablements
* Remove stale ban-ts-comment disablements
* Remove stale no-var disablements
* Remove stale no-empty-property disablements
* Remove stale react rule disablements
* Remove stale no-constant-condition disablements
* Remove stale no-unused-vars disablements
* Remove stale disablements for disabled rules
* fixup camelcase
* Remove dead code
* Tidy code
* Tweak oxlint config
2026-07-17 07:55:31 +00:00
Michael Telatynski and GitHub
c6b52b8a73
Fix credentials fixture when used with MAS ( #34234 )
...
* Fix credentials fixture when used with MAS
Without this it'd be using a Native OAuth2 session token but Element Web wouldn't know it was OAuth2-native and thus things like logout were broken
* Test by augmenting the dehydration test which previously failed using the `user` fixture
* Discard changes to apps/web/playwright/e2e/crypto/dehydration-mas.spec.ts
2026-07-13 16:31:57 +00:00
Michael Telatynski and GitHub
15c85ec50f
Switch from eslint to oxlint ( #34166 )
...
* Fix type imports
* Fix jsdoc
* Fixup types
* Fix stray awaits on non-thenables
* Fixup imports
* Fix splats
* Fix this-context on callbacks
* Memoise react contexts
* Prefer find/flatMap
* Make oxlint happier about our React keys
* Avoid unsafe default function params
* Fixup jsdoc
* Fixup contexts
* Switch from eslint to oxlint
* Some oxlint-related tweaks
* Iterate
* Partial revert to defer some changes and shrink diff
* Iterate
* Add eslint-plugin-element-call and enable the copyright rule
* Set strictStorePkgContentCheck
* Iterate
* Make sonar happy
* Fix new lints
2026-07-10 09:47:41 +00:00
Michael Telatynski and GitHub
d4f72dfa69
Start consolidating shared types in the monorepo ( #34062 )
...
* Start consolidating shared types in the monorepo
* Iterate
* Simplify api-extractor
* Iterate
* Fix lockfile
2026-07-06 13:49:32 +00:00
Richard van der Hoff and GitHub
28c9eed57a
Document incompatibility between playwright fixtures and MAS ( #34101 )
...
* Document incompatibility between playwright fixtures and MAS
* another comment
2026-07-02 14:48:16 +00:00
Richard van der Hoff and GitHub
f93f68056a
Improve accessibility of playwright fixture documentation ( #34087 )
...
* Improve accessibility of playwright fixture documentation
Empirically. by pulling the type definitions for the playwright fixtures out to
a type alias, we get better documentation for those fixtures.
* Exclude playwright-common from coverage checks
2026-07-02 11:18:14 +00:00
Will Hunt and GitHub
0889cca885
Update Retention Playwright tests to use real Synapse config endpoint ( #33906 )
...
* Use real interface type for SynapseConfig
* Reconfigure for Synapse retention config
* Add beforeEach
* fix import
* lint lint
* fix number type
* fix
* cleanup
* formatted
2026-06-19 17:03:09 +00:00
Florian Duros and GitHub
338c18df16
Room list: add release announcement for sections ( #33800 )
...
* feat: add release announcement for sections
* test: update screenshot
* test: update tests
* test: add release annoucement utils to close it
* test: close release announcement in custom section tests
* test: update release announcement e2e test
* test: add more tests
* feat: update Ra labels
* test: update screenshot
* chore: remove stale screenshot
2026-06-19 12:06:58 +00:00
Michael Telatynski and GitHub
8a31c7344f
Fix playwright-common Dockerfile ( #33855 )
...
* Fix playwright-common Dockerfile
ARG needs putting before the FROM to use it in the FROM, and after the FROM to use it within the stage.
* Apply suggestion from @t3chguy
2026-06-17 10:20:33 +00:00
Michael Telatynski
4825a5a4a4
Tidy deps
2026-06-08 10:33:09 +01:00
Michael Telatynski and GitHub
afc4e52df4
Report on Playwright flakes in the merge queue ( #33750 )
2026-06-04 17:03:19 +00:00
d6e4454ffa
Update testcontainers to v12 ( #33662 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-05-29 09:24:43 +00:00
David Baker and GitHub
0ed98941bd
Fix playwright screenshot consistency ( #33645 )
...
Add the --unsafe flag because we like to live dangerously, as commented.
2026-05-28 15:08:19 +00:00
Michael Telatynski and GitHub
013413c27a
Delete packages/playwright-common/src/@types/playwright-core.d.ts ( #33631 )
...
As identified in https://github.com/element-hq/element-web/pull/33592 this is no longer accessible
2026-05-28 07:58:34 +00:00
R Midhun Suresh and GitHub
bc7ac39d5b
Use the separator as border between roomlist and main panel ( #33598 )
...
* Remove border from roomlist container
The separator will act as the border so we no longer need the roomlist
border.
* Use pointer events to detect click event
Otherwise the onClick handler would run when you resize the panel.
* Support showing the border in separator
* Update tests
* Disable double click behaviour on separator
* Fix screenshot tests failing
2026-05-26 11:22:41 +01:00
David Baker
8e42cf7298
Bump to 6.0.0
2026-05-22 15:23:30 +01:00
David Baker and GitHub
7e3d6bf562
Fix playwright tests ( #33592 )
...
* Fix playwright tests
The screenshot reporter was using an import that no longer works as
of playwright 1.60. Inline the function instead as it doesn't seem
to be importable.
* Our custom expect was importing itself?
How did that ever work?
* Nope, that doesn't seem to help
and also it was aiming the in in playwright common which should be the 2nd level of extension
* Provide non-overridden version of the same function
as per comment
2026-05-22 15:01:08 +01:00
David Baker and GitHub
e46a9bddaf
Pass tags with INPUT_TAGS in docker bake job ( #33574 )
...
* Pass tags with INPUT_TAGS in docker bake job
Truly hideous mess of shell to set both env vars in the prebuild step.
As the env var doesn't seem to be available to the actual executor
but clearly must be available to the docker that it runs.
* gnore printf, it's a shell builtin
2026-05-21 13:30:30 +01:00
R Midhun Suresh and GitHub
7ce368537b
Stabilize playwright tests by making the left panel constant width ( #33451 )
...
* Move css injection to panel.ts
- Inject css on event
* Upgrade package
* Fix playwright tests
* Remove RR instead of masking it
* Fix wrong import
* Fix playwright tests
* Fix more playwright tests
* Catch error and add comment
2026-05-21 09:49:03 +01:00
David Baker and GitHub
ba3682074b
Another attempt at fixing the docker bake error ( #33535 )
...
Turns out the .env.docker:build is read automatically by nx when running
that project step, so it should be in the env. It might just be that using
the `x=$x` format means docker gets the $ literally because no shell is involved
here, so we need to use the plain `x` format so docker knows to take it from
the environment itself.
That's the theory, anyway.
2026-05-20 11:20:54 +00:00
David Baker and GitHub
0140563b64
Tweak new user menu design ( #33444 )
...
* Tweak new user menu design
* Update screenshots
* More screenshots
* Add story with no avatar
* add story to test
* Expand the menu so it actually shows what it's supposed to show
* Use the open parameter
which is the param to open the menu
* snapshot
* Add test for normal open menu version
* Move menu to the right of the avatar
and make it appear on top of the display name
* Fix user menu layout
* screenshots
* snapshot
* screenshots
* more screenshots
* Shift toasts to the left slightly
So they completely cover the display name of the user menu when
it's expanded. Also down slightly so they're level with the user menu.
* Tweak toast border radius & position
to match & sit on top of the user menu
* Close toasts in cider tests
* Only close the toast if it's actually there
* Fix some toasts to be dismissed & update screenshots
more to come though
* Make closeKeyStorageToast actually optional
* Fix some more toasts & races
* Screenshots again again (again)
* More screenshots
* Convert to rejectToast
* Fix toast rejectors to not wait and update screenshots
* Apparently 1ms is not long enough
2026-05-19 13:10:14 +00:00
Andy Balaam and GitHub
714bc20718
Remove toasts fixture from playwright-common: use rejectToast etc. directly. ( #33520 )
2026-05-18 12:40:02 +00:00
Andy Balaam and GitHub
1922266ba7
Bump @element-hq/element-web-playwright-common version to 4.1.0 ( #33500 )
2026-05-15 11:33:32 +00:00
Andy Balaam and GitHub
cff2c4cd25
Replace toasts fixture in playwright-common with utility functions. ( #33152 )
...
* Provide toasts utility functions, soon to replace the toasts fixture.
* Review suggestions
2026-05-14 14:29:13 +00:00
David Baker and GitHub
b6c24cb04f
Use the env file when buiding playwright common docker ( #33483 )
...
* Use the env file when buiding playwrigt common docker
The docker builds failed due to the variable for being available
* Also we surely don't need this twice
2026-05-13 13:07:16 +00:00
9a5f940787
Update dependency mailpit-api to v2 ( #33317 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-04-28 13:14:05 +00:00
Michael Telatynski and GitHub
12df09bd4b
Move playwright-common wait-on from devDependencies to dependencies ( #33272 )
...
as it is needed by the `playwright-screenshots.sh` script which is exposed to dependants
2026-04-23 07:51:39 +00:00
2d16498fe6
Update dependency typescript to v6 ( #32927 )
...
* Update dependency typescript to v6
* Switch to unplugin-vts
Workaround for https://github.com/qmhc/unplugin-dts/issues/467
And tweak tsconfigs
* tweak tsconfig
* Make tsc happy
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com >
2026-04-22 12:28:54 +00:00
Michael Telatynski and GitHub
133a56da65
Playwright docker improvements ( #33213 )
...
* Clean up playwright-common Dockerfile
* Speed up element-web docker build
* Wire up element-desktop playwright tests via nx
* Better debug logs for Element Desktop playwright in CI
* Iterate
* Iterate
* Fix element-desktop screenshot docker
* @electron/fuses
* Partial revert
2026-04-21 09:58:16 +00:00
Andy Balaam and GitHub
abae870b83
Improve the toasts fixture of the playwright-common tools ( #33158 )
...
* Improve the toasts fixture of the playwright-common tools
* Increase @element-hq/element-web-playwright-common version to 3.2.0
* Default to 2 second wait for IfExists variants
* Set playwright-common version to 4.0.0 due to breaking change
* Move handleToast into a free function
* Rename handleToast to clickToastButton
* Document new param on clickToastButton
2026-04-17 09:15:22 +00:00
Richard van der Hoff and GitHub
733755abb2
Annotate output from playwright-screenshots scripts ( #33176 )
...
... to make it easier to see where it is coming from
Also, add a blank line before starting playwright itself
2026-04-16 15:26:04 +00:00
Andy Balaam and GitHub
9a8ffbe0bd
playwright-common utilities for handling toasts ( #33119 )
...
* playwright-common utilities for handling toasts
* Set element-web-playwright-common version to 3.1.0
* Add comments to explain the linear hierarchy of fixtures
2026-04-14 11:49:27 +00:00
Michael Telatynski
7010f2091c
Absorb element-modules/packages/element-web-module-api into monorepo
2026-04-13 11:10:11 +01:00
Michael Telatynski
1096ca2066
Iterate
2026-04-10 17:39:46 +01:00
Michael Telatynski
ec924deaa0
Merge branch 'develop' of ssh://github.com/element-hq/element-web into t3chguy/monorepo-playwright-common
...
# Conflicts:
# pnpm-lock.yaml
2026-04-10 16:41:45 +01:00
Richard van der Hoff and GitHub
a132b9167d
Fix playwright-server docker image not exiting ( #33099 )
...
* Fix playwright-server docker image not exiting
... by wrapping with tini
* Remove redundant `npm exec`
* Update packages/playwright-common/Dockerfile
* missing comma
2026-04-10 12:31:03 +00:00
Richard van der Hoff and GitHub
b860a3864d
Improve output of playwright-screenshots script ( #33098 )
...
* Improve output of playwright-screenshots script
* Address review feedback
2026-04-10 11:50:12 +00:00
Michael Telatynski and GitHub
b6b0b0009c
Fix some flaky playwright tests ( #33085 )
...
* Tweak flaky test reporter to identify setup failures
* Fix some flaky playwright tests
* Iterate
2026-04-09 14:34:48 +00:00
Michael Telatynski
561dbd32be
Iterate
2026-04-09 15:31:34 +01:00
Michael Telatynski
540e620f40
Adjust consumers of playwright-common
2026-04-09 15:22:56 +01:00
Michael Telatynski
03e12cbd22
Absorb element-modules/packages/element-web-playwright-common into monorepo
2026-04-09 15:17:15 +01:00
Michael Telatynski
5e80431399
Shorten path for playwright-commmon
2026-04-09 14:35:32 +01:00
Michael Telatynski and GitHub
2b3720b4a2
Consolidate Build & Test CI ( #32929 )
...
* Consolidate Build & Test CI
* Add missing workflow dependency
* Fix artifact name clash
* Fix playwright config
* Fix playwright_ew job
* Fix ed tests
* Fix playwright tags
* Iterate
* Fix file reads
* Fix sample-files paths
* Fix PW_TAG
* Fix blob report paths
* Delint
* Fix build-and-test.yaml
* Iterate
* Fix consentHomeserver.ts
* Simplify
* Iterate
* Delint
* Iterate
* Iterate
* Iterate
* Specify shell
* Simplify
* Delete apps/web/playwright/sample-files/index.ts
* Discard changes to apps/web/playwright/sample-files/index.ts
* Exclude playwright-common from coverage gate
* Attempt to speed up arm64 desktop test
* Revert "Attempt to speed up arm64 desktop test"
This reverts commit 8fa8ff0c785da6dad05bda938c8af24fa6af0451.
* Iterate
* Fix cache key
* Accept python or python3 as per node-gyp
* Accept python or python3 as per node-gypd
* Exclude apps/desktop/hak from coverage gate
2026-03-31 12:52:50 +00:00
Michael Telatynski and GitHub
fc870bd676
Fix playwright tests locally ( #32974 )
2026-03-31 07:54:23 +00:00
Michael Telatynski and GitHub
efd2636824
Fix docker image signing v2 ( #32956 )
...
* Tweak cd.yaml workflow
* Tweak cd.yaml workflow
* Iterate
* Iterate
* Iterate
* Iterate
* Remove debug
2026-03-27 09:13:20 +00:00
Michael Telatynski and GitHub
f573ba4084
Consolidate ED dockerbuild into CD nx workflow ( #32923 )
...
* Consolidate ED dockerbuild into CD nx workflow
* Touch Dockerfile to convince CI to be happy
2026-03-26 13:39:39 +00:00
rbondesson and GitHub
e4ed5240e7
Fix playwright script in shared components ( #32743 )
2026-03-06 09:50:51 +00:00
Michael Telatynski and GitHub
32037b0135
Make knip happier ( #32721 )
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2026-03-05 21:42:08 +00:00
Michael TelatynskiandGitHub
Richard van der HoffandGitHub
Will HuntandGitHub
Florian DurosandGitHub
David BakerandGitHub
R Midhun SureshandGitHub
Andy BalaamandGitHub
rbondessonandGitHub