Florian DurosandGitHub
b68ecdb860
* refactor(room-list): migrate SpaceStore off the legacy room list store SpaceStore.setActiveRoomInSpace iterated the legacy RoomListStore's `orderedLists` in `TAG_ORDER`; switch it to the space-aware RoomListStoreV3.getSortedRoomsInActiveSpace() accessor. This drops the last non-UI dependency on the legacy store and on `TAG_ORDER` (exported from LegacyRoomList, deleted next). * feat(room-list)!: remove the legacy room list UI Delete the old sublist-based room list and its components now that the new RoomListPanel is the default. Removed: LegacyRoomList, LegacyRoomListHeader, RoomSublist, ExtraTile, RoomTile (+ Subtitle/ CallSummary), RoomBreadcrumbs and RoomSearch, plus their styles and tests. LeftPanel collapses to the RoomListPanel-only path. The shared `contextMenuBelow` helper is relocated into RoomResultContextMenus (its only remaining consumer). * feat(room-list)!: remove the legacy RoomListStore The legacy sublist-based room list UI is gone, so the old `stores/room-list` store (Algorithm, sorters, filters, layout store, space watcher) has no remaining consumers. Delete the directory and its tests. MatrixChat.forgetRoom no longer calls the legacy `manualRoomUpdate`; the new room list store removes the room on the `AfterForgetRoom` dispatch that still fires. Drop the `mxRoomListStore`/`mxRoomListLayoutStore` globals and the now-dead test imports. * feat(room-list)!: remove the feature_new_room_list labs flag The new room list is now the only room list, so remove the feature_new_room_list labs flag and make its enabled behaviour unconditional everywhere it was gated: - LoggedInView: always use the resizable layout and NEW_ROOM_LIST_MIN_WIDTH; drop the collapsible/minimized legacy path. - SpaceStore: People and Favourites are dropped from metaSpaceOrder (per the long-standing TODO on the removed accessor). - MessagePreviewStore: stop appending thread replies to previews. - Settings, SidebarUserSettingsTab, PreferencesUserSettingsTab, QuickSettingsButton, SpacePanel, LandmarkNavigation: drop the flag reads and legacy branches. Update the tests that toggled the flag; the People/Favourites meta space tests covered behaviour that the flag (default on) already disabled. * feat(room-list)!: remove the dead legacy left-panel resizer LoggedInView still built the old `Resizer`/`CollapseDistributor` over an `lp-resizer` ResizeHandle and persisted `mx_lhs_size`. That handle is no longer rendered (the resizable layout is now driven by LeftResizablePanelView + ResizerViewModel, which persists its own state via RoomList.panelSize/RoomList.isPanelCollapsed), so the old resizer was inert dead code left over from the legacy room list. Remove createResizer/loadResizer/loadResizerPreferences, the _resizeContainer/resizeHandler refs, the ResizeHandle render, the mx_lhs_size handling and NEW_ROOM_LIST_MIN_WIDTH, plus the unit tests that exercised the mocked resizer. * feat(room-list)!: update i18n files * refactor(room-list): remove the now-unused collapseLhs state `collapseLhs` is write-only since the left panel no longer collapses: it was last read by LoggedInView's `shouldUseMinimizedUI`, removed with the feature_new_room_list flag. Drop it from MatrixChat's IState (and its assignments), collapsing the hide/show_left_panel handlers to just the `notifyLeftHandleResized()` call they still need, and from LoggedInView's IProps and the test props. * fix(room-list): instantiate message previewers lazily Removing the unused SettingsStore import from MessagePreviewStore (when the feature_new_room_list flag was dropped) changed module load order and exposed a latent circular dependency: ReactionEventPreview imports MessagePreviewStore, which eagerly did `new ReactionEventPreview()` at module-eval — so importing ReactionEventPreview first (as its unit test does) hit "ReactionEventPreview is not a constructor". Construct the previewers lazily on first use (cached) instead of at module load, so nothing dereferences a mid-evaluation module. Fixes ReactionEventPreview-test. * test(room-list): remove `feature_new_room_list` labs flag in e2e tests * chore: remove remaining `newRoomList` flag * chore: cleanup theme files * fix: restore the re-resizable TouchEvent polyfill * chore: remove usage of breadcrumbs settings in BreadcrumbStore * Revert "fix(room-list): instantiate message previewers lazily" This reverts commit 4e6eedfff0449c68a96c0470a4eb425b5aec5512. * chore: remove unused function in BreadCrumbStore * test: remove unused fuction of BreadcrumStore in tests * test: add tests for RoomResultContextMenu
79 lines
3.4 KiB
TypeScript
79 lines
3.4 KiB
TypeScript
/*
|
|
Copyright 2024 New Vector Ltd.
|
|
Copyright 2024 The Matrix.org Foundation C.I.C.
|
|
Copyright 2023 Suguru Hirahara
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
|
|
import { test, expect } from "../../element-web-test";
|
|
|
|
test.use({
|
|
locale: "en-GB",
|
|
timezoneId: "Europe/London",
|
|
});
|
|
|
|
test.describe("Preferences user settings tab", () => {
|
|
test.use({
|
|
displayName: "Bob",
|
|
uut: async ({ app, user }, use) => {
|
|
const locator = await app.settings.openUserSettings("Preferences");
|
|
await use(locator);
|
|
},
|
|
});
|
|
|
|
test("should be rendered properly", { tag: "@screenshot" }, async ({ app, page, user, axe }) => {
|
|
await page.setViewportSize({ width: 1024, height: 4000 });
|
|
const tab = await app.settings.openUserSettings("Preferences");
|
|
// Assert that the top heading is rendered
|
|
await expect(tab.getByRole("heading", { name: "Preferences" })).toBeVisible();
|
|
await expect(tab).toMatchScreenshot("Preferences-user-settings-tab-should-be-rendered-properly-1.png", {
|
|
// masked with fixed-width due to daylight saving time making the text content vary
|
|
mask: [tab.locator("#mx_dropdownUserTimezone_value")],
|
|
css: `
|
|
#mx_dropdownUserTimezone_value {
|
|
width: 200px;
|
|
}
|
|
`,
|
|
});
|
|
|
|
await expect(axe).toHaveNoViolations();
|
|
});
|
|
|
|
test("should be able to change the app language", { tag: ["@no-firefox", "@no-webkit"] }, async ({ uut, user }) => {
|
|
// Check language and region setting dropdown
|
|
const languageInput = uut.getByRole("button", { name: "Language Dropdown" });
|
|
await languageInput.scrollIntoViewIfNeeded();
|
|
// Check the default value
|
|
await expect(languageInput.getByText("English")).toBeVisible();
|
|
// Click the button to display the dropdown menu
|
|
await languageInput.click();
|
|
// Assert that the default option is rendered and highlighted
|
|
languageInput.getByRole("option", { name: /Albanian/ });
|
|
await expect(languageInput.getByRole("option", { name: /Albanian/ })).toHaveClass(
|
|
/mx_Dropdown_option_highlight/,
|
|
);
|
|
await expect(languageInput.getByRole("option", { name: /Deutsch/ })).toBeVisible();
|
|
// Click again to close the dropdown
|
|
await languageInput.click();
|
|
// Assert that the default value is rendered again
|
|
await expect(languageInput.getByText("English")).toBeVisible();
|
|
});
|
|
|
|
test("should be able to change the timezone", async ({ uut, user }) => {
|
|
// Check language and region setting dropdown
|
|
const timezoneInput = uut.locator(".mx_dropdownUserTimezone");
|
|
const timezoneValue = uut.locator("#mx_dropdownUserTimezone_value");
|
|
await timezoneInput.scrollIntoViewIfNeeded();
|
|
// Check the default value
|
|
await expect(timezoneValue.getByText("Browser default")).toBeVisible();
|
|
// Click the button to display the dropdown menu
|
|
await timezoneInput.getByRole("button", { name: "Set timezone" }).click();
|
|
// Select a different value
|
|
await timezoneInput.getByRole("option", { name: /Africa\/Abidjan/ }).click();
|
|
// Check the new value
|
|
await expect(timezoneValue.getByText("Africa/Abidjan")).toBeVisible();
|
|
});
|
|
});
|