* refactor(room-list): migrate SpaceStore off the legacy room list store SpaceStore.setActiveRoomInSpace iterated the legacy RoomListStore's `orderedLists` in `TAG_ORDER`; switch it to the space-aware RoomListStoreV3.getSortedRoomsInActiveSpace() accessor. This drops the last non-UI dependency on the legacy store and on `TAG_ORDER` (exported from LegacyRoomList, deleted next). * feat(room-list)!: remove the legacy room list UI Delete the old sublist-based room list and its components now that the new RoomListPanel is the default. Removed: LegacyRoomList, LegacyRoomListHeader, RoomSublist, ExtraTile, RoomTile (+ Subtitle/ CallSummary), RoomBreadcrumbs and RoomSearch, plus their styles and tests. LeftPanel collapses to the RoomListPanel-only path. The shared `contextMenuBelow` helper is relocated into RoomResultContextMenus (its only remaining consumer). * feat(room-list)!: remove the legacy RoomListStore The legacy sublist-based room list UI is gone, so the old `stores/room-list` store (Algorithm, sorters, filters, layout store, space watcher) has no remaining consumers. Delete the directory and its tests. MatrixChat.forgetRoom no longer calls the legacy `manualRoomUpdate`; the new room list store removes the room on the `AfterForgetRoom` dispatch that still fires. Drop the `mxRoomListStore`/`mxRoomListLayoutStore` globals and the now-dead test imports. * feat(room-list)!: remove the feature_new_room_list labs flag The new room list is now the only room list, so remove the feature_new_room_list labs flag and make its enabled behaviour unconditional everywhere it was gated: - LoggedInView: always use the resizable layout and NEW_ROOM_LIST_MIN_WIDTH; drop the collapsible/minimized legacy path. - SpaceStore: People and Favourites are dropped from metaSpaceOrder (per the long-standing TODO on the removed accessor). - MessagePreviewStore: stop appending thread replies to previews. - Settings, SidebarUserSettingsTab, PreferencesUserSettingsTab, QuickSettingsButton, SpacePanel, LandmarkNavigation: drop the flag reads and legacy branches. Update the tests that toggled the flag; the People/Favourites meta space tests covered behaviour that the flag (default on) already disabled. * feat(room-list)!: remove the dead legacy left-panel resizer LoggedInView still built the old `Resizer`/`CollapseDistributor` over an `lp-resizer` ResizeHandle and persisted `mx_lhs_size`. That handle is no longer rendered (the resizable layout is now driven by LeftResizablePanelView + ResizerViewModel, which persists its own state via RoomList.panelSize/RoomList.isPanelCollapsed), so the old resizer was inert dead code left over from the legacy room list. Remove createResizer/loadResizer/loadResizerPreferences, the _resizeContainer/resizeHandler refs, the ResizeHandle render, the mx_lhs_size handling and NEW_ROOM_LIST_MIN_WIDTH, plus the unit tests that exercised the mocked resizer. * feat(room-list)!: update i18n files * refactor(room-list): remove the now-unused collapseLhs state `collapseLhs` is write-only since the left panel no longer collapses: it was last read by LoggedInView's `shouldUseMinimizedUI`, removed with the feature_new_room_list flag. Drop it from MatrixChat's IState (and its assignments), collapsing the hide/show_left_panel handlers to just the `notifyLeftHandleResized()` call they still need, and from LoggedInView's IProps and the test props. * fix(room-list): instantiate message previewers lazily Removing the unused SettingsStore import from MessagePreviewStore (when the feature_new_room_list flag was dropped) changed module load order and exposed a latent circular dependency: ReactionEventPreview imports MessagePreviewStore, which eagerly did `new ReactionEventPreview()` at module-eval — so importing ReactionEventPreview first (as its unit test does) hit "ReactionEventPreview is not a constructor". Construct the previewers lazily on first use (cached) instead of at module load, so nothing dereferences a mid-evaluation module. Fixes ReactionEventPreview-test. * test(room-list): remove `feature_new_room_list` labs flag in e2e tests * chore: remove remaining `newRoomList` flag * chore: cleanup theme files * fix: restore the re-resizable TouchEvent polyfill * chore: remove usage of breadcrumbs settings in BreadcrumbStore * Revert "fix(room-list): instantiate message previewers lazily" This reverts commit 4e6eedfff0449c68a96c0470a4eb425b5aec5512. * chore: remove unused function in BreadCrumbStore * test: remove unused fuction of BreadcrumStore in tests * test: add tests for RoomResultContextMenu
128 lines
4.8 KiB
TypeScript
128 lines
4.8 KiB
TypeScript
/*
|
|
Copyright 2024 New Vector Ltd.
|
|
Copyright 2020, 2021 The Matrix.org Foundation C.I.C.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
|
|
import { arrayDiff, arrayUnion, arrayIntersection } from "./arrays";
|
|
|
|
type ObjectExcluding<O extends object, P extends (keyof O)[]> = { [k in Exclude<keyof O, P[number]>]: O[k] };
|
|
|
|
/**
|
|
* Gets a new object which represents the provided object, excluding some properties.
|
|
* @param a The object to strip properties of. Must be defined.
|
|
* @param props The property names to remove.
|
|
* @returns The new object without the provided properties.
|
|
*/
|
|
export function objectExcluding<O extends object, P extends Array<keyof O>>(a: O, props: P): ObjectExcluding<O, P> {
|
|
// We use a Map to avoid hammering the `delete` keyword, which is slow and painful.
|
|
const tempMap = new Map<keyof O, any>(Object.entries(a) as [keyof O, any][]);
|
|
for (const prop of props) {
|
|
tempMap.delete(prop);
|
|
}
|
|
|
|
// Convert the map to an object again
|
|
return Array.from(tempMap.entries()).reduce((c, [k, v]) => {
|
|
c[k] = v;
|
|
return c;
|
|
}, {} as O);
|
|
}
|
|
|
|
/**
|
|
* Clones an object to a caller-controlled depth. When a propertyCloner is supplied, the
|
|
* object's properties will be passed through it with the return value used as the new
|
|
* object's type. This is intended to be used to deep clone a reference, but without
|
|
* having to deep clone the entire object. This function is safe to call recursively within
|
|
* the propertyCloner.
|
|
* @param a The object to clone. Must be defined.
|
|
* @param propertyCloner The function to clone the properties of the object with, optionally.
|
|
* First argument is the property key with the second being the current value.
|
|
* @returns A cloned object.
|
|
*/
|
|
export function objectShallowClone<O extends object>(a: O, propertyCloner?: (k: keyof O, v: O[keyof O]) => any): O {
|
|
const newObj = {} as O;
|
|
for (const [k, v] of Object.entries(a) as [keyof O, O[keyof O]][]) {
|
|
newObj[k] = v;
|
|
if (propertyCloner) {
|
|
newObj[k] = propertyCloner(k, v);
|
|
}
|
|
}
|
|
return newObj;
|
|
}
|
|
|
|
/**
|
|
* Determines if any keys were added, removed, or changed between two objects.
|
|
* For changes, simple triple equal comparisons are done, not in-depth
|
|
* tree checking.
|
|
* @param a The first object. Must be defined.
|
|
* @param b The second object. Must be defined.
|
|
* @returns True if there's a difference between the objects, false otherwise
|
|
*/
|
|
export function objectHasDiff<O extends object>(a: O, b: O): boolean {
|
|
if (a === b) return false;
|
|
const aKeys = Object.keys(a);
|
|
const bKeys = Object.keys(b);
|
|
if (aKeys.length !== bKeys.length) return true;
|
|
const possibleChanges = arrayIntersection(aKeys, bKeys) as Array<keyof O>;
|
|
// if the amalgamation of both sets of keys has the a different length to the inputs then there must be a change
|
|
if (possibleChanges.length !== aKeys.length) return true;
|
|
|
|
return possibleChanges.some((k) => a[k] !== b[k]);
|
|
}
|
|
|
|
type Diff<K> = { changed: K[]; added: K[]; removed: K[] };
|
|
|
|
/**
|
|
* Determines the keys added, changed, and removed between two objects.
|
|
* For changes, simple triple equal comparisons are done, not in-depth
|
|
* tree checking.
|
|
* @param a The first object. Must be defined.
|
|
* @param b The second object. Must be defined.
|
|
* @returns The difference between the keys of each object.
|
|
*/
|
|
export function objectDiff<O extends object>(a: O, b: O): Diff<keyof O> {
|
|
const aKeys = Object.keys(a) as (keyof O)[];
|
|
const bKeys = Object.keys(b) as (keyof O)[];
|
|
const keyDiff = arrayDiff(aKeys, bKeys);
|
|
const possibleChanges = arrayIntersection(aKeys, bKeys);
|
|
const changes = possibleChanges.filter((k) => a[k] !== b[k]);
|
|
|
|
return { changed: changes, added: keyDiff.added, removed: keyDiff.removed };
|
|
}
|
|
|
|
/**
|
|
* Gets all the key changes (added, removed, or value difference) between
|
|
* two objects. Triple equals is used to compare values, not in-depth tree
|
|
* checking.
|
|
* @param a The first object. Must be defined.
|
|
* @param b The second object. Must be defined.
|
|
* @returns The keys which have been added, removed, or changed between the
|
|
* two objects.
|
|
*/
|
|
export function objectKeyChanges<O extends object>(a: O, b: O): (keyof O)[] {
|
|
const diff = objectDiff(a, b);
|
|
return arrayUnion(diff.removed, diff.added, diff.changed);
|
|
}
|
|
|
|
/**
|
|
* Clones an object by running it through JSON parsing. Note that this
|
|
* will destroy any complicated object types which do not translate to
|
|
* JSON.
|
|
* @param obj The object to clone.
|
|
* @returns The cloned object
|
|
*/
|
|
export function objectClone<O extends object>(obj: O): O {
|
|
return JSON.parse(JSON.stringify(obj));
|
|
}
|
|
|
|
/**
|
|
* Simple object check.
|
|
* @param item
|
|
* @returns {boolean}
|
|
*/
|
|
export function isObject(item: any): item is object {
|
|
return item && typeof item === "object" && !Array.isArray(item);
|
|
}
|