Florian DurosandGitHub
be7be39d0f
* refactor: transform `FontWater.onAction` to switch * fix: reload font after switching theme Fix #26248 #31588 When a theme is swiched, `clearCustomTheme` remove all css variables. After the styles are re-applied but the custom fonts or emoji are not re-applied. * test: add test for `Action.ReloadFont` * test: add missing tests for existing actions * test(e2e): add tests to ensure that font and emoji stay unchanged * Revert "fix: reload font after switching theme" This reverts commit 2b0071af21c38bf2c86780356aa39d290e9d9148. * Revert "refactor: transform `FontWater.onAction` to switch" This reverts commit 411915860923230cabce3ad5498fb46696a9a65e. * Revert "test: add test for `Action.ReloadFont`" This reverts commit 31b3b224cd2c443663a2b9bba312a4140907a8ed. * fix: don't remove custom emoji and cpd font when clearing custom theme Fix #26248 #31588 When a theme is swiched, `clearCustomTheme` remove all css variables. After the styles are re-applied but the custom fonts or emoji are not re-applied. This fix avoid the custom font and emoji to be removed. * test: add tests
91 lines
3.6 KiB
TypeScript
91 lines
3.6 KiB
TypeScript
/*
|
|
Copyright 2024,2025 New Vector Ltd.
|
|
Copyright 2023 Suguru Hirahara
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
|
|
import { expect, test } from ".";
|
|
|
|
test.describe("Appearance user settings tab", () => {
|
|
test.use({
|
|
displayName: "Hanako",
|
|
});
|
|
|
|
test("should be rendered properly", { tag: "@screenshot" }, async ({ page, user, app }) => {
|
|
const tab = await app.settings.openUserSettings("Appearance");
|
|
|
|
// Click "Show advanced" link button
|
|
await tab.getByRole("button", { name: "Show advanced" }).click();
|
|
|
|
// Assert that "Hide advanced" link button is rendered
|
|
await expect(tab.getByRole("button", { name: "Hide advanced" })).toBeVisible();
|
|
|
|
await expect(tab).toMatchScreenshot("appearance-tab.png");
|
|
});
|
|
|
|
test(
|
|
"should support changing font size by using the font size dropdown",
|
|
{ tag: "@screenshot" },
|
|
async ({ page, app, user }) => {
|
|
await app.settings.openUserSettings("Appearance");
|
|
|
|
const tab = page.getByTestId("mx_AppearanceUserSettingsTab");
|
|
const fontDropdown = tab.locator(".mx_FontScalingPanel_Dropdown");
|
|
await expect(fontDropdown.getByLabel("Font size")).toBeVisible();
|
|
|
|
// Default browser font size is 16px and the select value is 0
|
|
// -4 value is 12px
|
|
await fontDropdown.getByLabel("Font size").selectOption({ value: "-4" });
|
|
|
|
await expect(page).toMatchScreenshot("window-12px.png", { includeDialogBackground: true });
|
|
},
|
|
);
|
|
|
|
test("should support enabling system font", async ({ page, app, user }) => {
|
|
await app.settings.openUserSettings("Appearance");
|
|
const tab = page.getByTestId("mx_AppearanceUserSettingsTab");
|
|
|
|
// Click "Show advanced" link button
|
|
await tab.getByRole("button", { name: "Show advanced" }).click();
|
|
|
|
await tab.getByRole("switch", { name: "Use bundled emoji font" }).click();
|
|
await tab.getByRole("switch", { name: "Use a system font" }).click();
|
|
|
|
// Assert that the font-family value was removed
|
|
await expect(page.locator("body")).toHaveCSS("font-family", '""');
|
|
});
|
|
|
|
test(
|
|
"should keep same font and emoji when switching theme",
|
|
{ tag: "@screenshot" },
|
|
async ({ page, app, user, util }) => {
|
|
const roomId = await util.createAndDisplayRoom();
|
|
await app.client.sendMessage(roomId, { body: "Message with 🦡", msgtype: "m.text" });
|
|
|
|
await app.settings.openUserSettings("Appearance");
|
|
const tab = page.getByTestId("mx_AppearanceUserSettingsTab");
|
|
await tab.getByRole("button", { name: "Show advanced" }).click();
|
|
await tab.getByRole("switch", { name: "Use bundled emoji font" }).click();
|
|
await tab.getByRole("switch", { name: "Use a system font" }).click();
|
|
|
|
await app.closeDialog();
|
|
await expect(page).toMatchScreenshot("window-before-switch.png", {
|
|
mask: [page.locator(".mx_MessageTimestamp")],
|
|
});
|
|
|
|
// Switch to dark theme
|
|
await app.settings.openUserSettings("Appearance");
|
|
await util.getMatchSystemThemeSwitch().click();
|
|
await util.getDarkTheme().click();
|
|
|
|
await app.closeDialog();
|
|
// Font and emoji should remain the same after theme switch
|
|
await expect(page).toMatchScreenshot("window-after-switch.png", {
|
|
mask: [page.locator(".mx_MessageTimestamp")],
|
|
});
|
|
},
|
|
);
|
|
});
|