Update button in incoming call toast to say 'Decline' (#33405)
* Update button in incoming call toast to say 'Decline' Rather than 'Ignore'. This change has been agreed with design since 'Ignore' did not properly communicate that clicking the button would inform the caller that you deliberately rejected their call. * Update incoming call toast screenshots
|
Before Width: | Height: | Size: 13 KiB After Width: | Height: | Size: 13 KiB |
|
Before Width: | Height: | Size: 13 KiB After Width: | Height: | Size: 13 KiB |
|
Before Width: | Height: | Size: 10 KiB After Width: | Height: | Size: 10 KiB |
|
Before Width: | Height: | Size: 14 KiB After Width: | Height: | Size: 14 KiB |
|
Before Width: | Height: | Size: 15 KiB After Width: | Height: | Size: 15 KiB |
|
Before Width: | Height: | Size: 12 KiB After Width: | Height: | Size: 12 KiB |
@@ -142,7 +142,7 @@ function DeclineCallButtonWithNotificationEvent({
|
||||
Icon={CloseIcon}
|
||||
size="md"
|
||||
>
|
||||
{_t("action|ignore")}
|
||||
{_t("action|decline")}
|
||||
</Button>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -167,7 +167,7 @@ describe("IncomingCallToast", () => {
|
||||
screen.getByText("on the call");
|
||||
|
||||
screen.getByRole("button", { name: "Join" });
|
||||
screen.getByRole("button", { name: "Ignore" });
|
||||
screen.getByRole("button", { name: "Decline" });
|
||||
screen.getByRole("button", { name: "Expand" });
|
||||
});
|
||||
|
||||
@@ -187,7 +187,7 @@ describe("IncomingCallToast", () => {
|
||||
screen.getByLabelText("@alice:example.org");
|
||||
|
||||
screen.getByRole("button", { name: "Join" });
|
||||
screen.getByRole("button", { name: "Ignore" });
|
||||
screen.getByRole("button", { name: "Decline" });
|
||||
screen.getByRole("button", { name: "Expand" });
|
||||
} finally {
|
||||
mocked(dmRoomMap.getUserIdForRoomId).mockReset();
|
||||
@@ -210,7 +210,7 @@ describe("IncomingCallToast", () => {
|
||||
expect(screen.queryByText("on the call")).toBe(null);
|
||||
|
||||
screen.getByRole("button", { name: "Join" });
|
||||
screen.getByRole("button", { name: "Ignore" });
|
||||
screen.getByRole("button", { name: "Decline" });
|
||||
screen.getByRole("button", { name: "Expand" });
|
||||
});
|
||||
|
||||
@@ -452,7 +452,7 @@ describe("IncomingCallToast", () => {
|
||||
return promise;
|
||||
});
|
||||
|
||||
fireEvent.click(screen.getByRole("button", { name: "Ignore" }));
|
||||
fireEvent.click(screen.getByRole("button", { name: "Decline" }));
|
||||
|
||||
expect(toastStore.dismissToast).not.toHaveBeenCalledWith(getIncomingCallToastKey(callId, room.roomId));
|
||||
expect(client.sendRtcDecline).toHaveBeenCalledWith("!1:example.org", "$notificationEventId");
|
||||
|
||||