Travis Ralston and GitHub
58a5b7f154
Merge pull request #4556 from matrix-org/travis/fix-reset
...
Ensure key backup gets dealt with correctly during secret storage reset
2020-05-11 14:30:12 -06:00
Travis Ralston and GitHub
2aa7a6087c
Merge pull request #4547 from matrix-org/travis/fix-user-panel
...
Don't try to reload profile information when closing the user panel
2020-05-07 10:21:17 -06:00
Travis Ralston and GitHub
7f030a149e
Merge pull request #4557 from matrix-org/travis/3pid-loading
...
Add a loading state for email addresses/phone numbers in settings
2020-05-06 17:03:42 -06:00
Travis Ralston
9ae812c346
Add a loading state for email addresses/phone numbers in settings
...
Fixes https://github.com/vector-im/riot-web/issues/13432
2020-05-06 15:17:55 -06:00
Travis Ralston
e5da81b6ba
Ensure key backup gets dealt with correctly during secret storage reset
...
Fixes https://github.com/vector-im/riot-web/issues/13562
We only initialize a new key backup if the user requested one. If they've requested new keys but have not asked for keys to be backed up, we simply delete the now-invalid backup.
This also adds some logging to identify in rageshakes when someone resets their cross-signing, and when their key backup is being deleted.
2020-05-06 14:42:03 -06:00
Travis Ralston and GitHub
19bb678dd6
Merge pull request #4554 from nimbleape/pwa-taskbar-colour-follow-theme
...
set the meta tag for theme-color to the same theme css background
2020-05-06 11:27:01 -06:00
Travis Ralston
9a14417a03
Don't try to reload profile information when closing the user panel
...
Fixes https://github.com/vector-im/riot-web/issues/13479
This looks to have been caused by something to do with the app load order, though where is a mystery. The view change seems to fire for the same page type despite a dispatch that says to change the view type.
Instead of debugging it too much further, we'll just patch around it.
This commit also makes the settings link use a more safe approach to viewing the user info - not going through the dispatcher means we are at the mercy of browser behaviour when we already have a loop which deals with this.
2020-05-04 15:41:26 -06:00
Travis Ralston and GitHub
7b775a8d93
Merge pull request #4271 from aaronraimist/esc-mark-as-read
...
Mark room as read when escape is pressed
2020-04-30 10:40:50 -06:00
Travis Ralston and GitHub
477875e012
Merge pull request #4488 from matrix-org/travis/release/labs-remove-padlocks
...
Remove invite only padlocks feature flag for release
2020-04-24 10:48:46 -06:00
Travis Ralston and GitHub
3b7cd3106e
Merge pull request #4487 from matrix-org/travis/labs-remove-padlocks
...
Remove invite only padlocks feature flag
2020-04-24 10:45:03 -06:00
Travis Ralston
353810ce63
Remove invite only padlocks feature flag
...
Fixes https://github.com/vector-im/riot-web/issues/13366
Only known issue on this is https://github.com/vector-im/riot-web/issues/12148
This has been pre-approved by Product.
2020-04-24 10:06:34 -06:00
Travis Ralston
117322b3b5
Remove invite only padlocks feature flag
...
Fixes https://github.com/vector-im/riot-web/issues/13366
Only known issue on this is https://github.com/vector-im/riot-web/issues/12148
This has been pre-approved by Product.
2020-04-24 10:05:28 -06:00
Travis Ralston and GitHub
d8eb761106
Merge pull request #4481 from matrix-org/travis/fix-widget-params-again
...
Fix widget URL templating (again)
2020-04-23 23:43:35 -06:00
Travis Ralston
50783c2432
Appease the linter
2020-04-23 23:25:53 -06:00
Travis Ralston
28865e27bc
Don't overwrite the 'domain' data key for all widgets
...
Some widgets, which aren't Jitsi widgets, might need this to be something else.
2020-04-23 15:24:27 -06:00
Travis Ralston
efaf4fbbda
Decode dollar signs in safe widget URLs before rendering/templating
...
Fixes https://github.com/vector-im/riot-web/issues/13344
2020-04-23 15:24:27 -06:00
Travis Ralston and GitHub
35dd892dce
Merge pull request #4458 from matrix-org/travis/fix-sticker-picker-add
...
Use WidgetType more often to avoid breaking new sticker pickers
2020-04-23 08:18:12 -06:00
Travis Ralston and GitHub
d66d497638
Merge pull request #4460 from matrix-org/travis/integ-logging
...
Update logging for unmanaged widgets, and add TODO comments for other areas
2020-04-23 08:17:54 -06:00
Travis Ralston and GitHub
3d4032e542
Merge pull request #4459 from matrix-org/travis/fix-openid-widget
...
Fix OpenID requests from widgets
2020-04-23 08:17:38 -06:00
Travis Ralston and GitHub
c7423a68cb
Merge pull request #4473 from matrix-org/travis/t3chguy/rel-i18n-sso
...
Fix i18n of SSO UIA copy in Deactivate Account Dialog on release
2020-04-22 15:37:02 -06:00
Travis Ralston
ab7d7becd7
Match settings paragraph style in all cases
2020-04-22 11:14:12 -06:00
Travis Ralston
50059373d2
Appease the linter
2020-04-22 11:14:03 -06:00
Travis Ralston
3c722d16ea
i18n
2020-04-22 11:13:57 -06:00
Travis Ralston
475cea8b8a
Take encrypted message search out of labs
...
Fixes https://github.com/vector-im/riot-web/issues/13262
This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* https://github.com/vector-im/riot-web/issues/12896
* https://github.com/vector-im/riot-web/issues/12385
* https://github.com/vector-im/riot-web/issues/11831
* https://github.com/vector-im/riot-web/issues/11155
In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
2020-04-22 11:13:21 -06:00
Travis Ralston
27138b33c0
Match settings paragraph style in all cases
2020-04-22 11:08:46 -06:00
Travis Ralston
3662c9e1c1
Appease the linter
2020-04-22 11:05:43 -06:00
Travis Ralston
5c77df2afd
i18n
2020-04-22 11:01:07 -06:00
Travis Ralston
fdcdd2529e
Take encrypted message search out of labs
...
Fixes https://github.com/vector-im/riot-web/issues/13262
This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* https://github.com/vector-im/riot-web/issues/12896
* https://github.com/vector-im/riot-web/issues/12385
* https://github.com/vector-im/riot-web/issues/11831
* https://github.com/vector-im/riot-web/issues/11155
In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
2020-04-22 10:58:11 -06:00
Travis Ralston
3a360b91b9
Update logging for unmanaged widgets, and add TODO comments for other areas
...
Just a minor thing that is bothersome. Renaming classes and functions is a bit more of an impact than is worth right now, so have settled for littering TODO comments all over the place.
2020-04-22 00:34:08 -06:00
Travis Ralston
d851f2e45f
Fix OpenID requests from widgets
...
Fixes https://github.com/vector-im/riot-web/issues/13131
Widgets can request an OpenID token to authenticate the user when the widget is missing authentication information. A common case for this is the Dimension sticker picker: sometimes the Riot is running in doesn't have the configuration to match the Dimension instance, so Riot rightly refuses to send an auth token to the widget. When this happens, it requests a token through postMessage().
There's a toggle on the permission dialog to remember the setting, which is the widget's security key. As an added measure, the security key generation ensures the widget URL matches as the 'remember this choice' toggle will silently work in the background, and it could be dangerous if the widget's URL changed and Riot secretly allows the widget to identify the user. This check was failing because the WidgetMessaging class was being set up with the rendered URL, which will not match the widget's URL at all. To fix this, we simply use the widget's URL to set up the messaging, which by proxy uses the right URL in calculating the security key.
2020-04-22 00:27:20 -06:00
Travis Ralston
f54e99c708
Use WidgetType more often to avoid breaking new sticker pickers
...
Turns out that setUserWidget() wasn't updated to take a real WidgetType, but the code in ScalarMessaging thought it did. This leads to integration managers trying to add sticker widgets with an object `type` rather than a string `type`, which doesn't work.
This updates other code paths which call into the various widget classes to use WidgetType more often. The actual code path for fixing widgets is resolved in WidgetUtils for the setUserWidget function body.
2020-04-21 16:01:10 -06:00
Travis Ralston and GitHub
5dca84379f
Merge pull request #4382 from matrix-org/travis/addwidget-improvements
...
Allow iframes and Jitsi URLs in /addwidget
2020-04-21 00:30:46 -06:00
36f154f2b2
Name Jitsi correctly in args
...
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com >
2020-04-20 09:35:35 -06:00
Travis Ralston and GitHub
37bd0f3508
Merge pull request #4379 from matrix-org/travis/moar-jitsi
...
Support m.jitsi-typed widgets as Jitsi widgets
2020-04-20 09:31:23 -06:00
Travis Ralston
a55698e943
Merge branch 'travis/moar-jitsi' into travis/addwidget-improvements
2020-04-20 09:22:38 -06:00
Travis Ralston
d8a5ba9b14
Merge branch 'develop' into travis/moar-jitsi
2020-04-20 09:21:48 -06:00
Travis Ralston and GitHub
a2a6dbc7ee
Merge pull request #4445 from matrix-org/revert-4388-thobyv/make-filepanel-remember-scroll-position
...
Revert "Fix Filepanel scroll position state lost when room is changed"
2020-04-19 19:14:20 -06:00
Travis Ralston and GitHub
972baa881b
Revert "Fix Filepanel scroll position state lost when room is changed"
2020-04-19 19:14:08 -06:00
Travis Ralston and GitHub
9e7b843f5d
Merge pull request #4388 from ThobyV/thobyv/make-filepanel-remember-scroll-position
...
Fix Filepanel scroll position state lost when room is changed
2020-04-17 15:24:52 -06:00
Travis Ralston
e0d6fa3f51
Rename ref to timelinePanel
2020-04-17 15:15:51 -06:00
Travis Ralston and GitHub
dd444ffa5d
Merge pull request #4436 from matrix-org/travis/e2e-e2e-tests
...
Fix end-to-end tests for end-to-end encryption verification
2020-04-17 15:14:12 -06:00
Travis Ralston
d910eb4d57
Merge branch 'develop' into thobyv/make-filepanel-remember-scroll-position
2020-04-17 15:10:12 -06:00
Travis Ralston
432dbab8cb
Fix start chat button variable name
2020-04-17 15:06:59 -06:00
Travis Ralston and GitHub
a234cb8a44
Merge pull request #4437 from matrix-org/travis/test-logs
...
Don't explode if the e2e test directory exists when crashing
2020-04-17 14:52:12 -06:00
Travis Ralston
88b5c3ca84
Don't explode if the e2e test directory exists when crashing
...
This is largely expected in local test environments where the developer probably won't remember to clear out the directory themselves.
2020-04-17 14:39:45 -06:00
Travis Ralston
77df610653
Appease the linter a bit more
2020-04-17 14:38:05 -06:00
Travis Ralston
5a9898591d
Appease the linter
2020-04-17 14:35:02 -06:00
Travis Ralston
e72008d7f1
Fix end-to-end tests for end-to-end encryption verification
...
Fixes https://github.com/vector-im/riot-web/issues/13226
This isn't the fastest route, but it is a predictable route for the happy path we probably want to test. For example, Alice will already be staring at the DM and could easily accept the verification there, but we probably want to make sure that the toast is present and does the right thing. Similarly, neither of them need to verify that there's green shields everywhere, they should be implied, however an explicit check follows a real user's gaze.
2020-04-17 14:31:33 -06:00
Travis Ralston and GitHub
885bb112ae
Merge pull request #4430 from matrix-org/dependabot/npm_and_yarn/test/end-to-end-tests/https-proxy-agent-2.2.4
...
Bump https-proxy-agent from 2.2.1 to 2.2.4 in /test/end-to-end-tests
2020-04-17 12:44:57 -06:00
Travis Ralston and GitHub
e485f7a82c
Merge pull request #4432 from matrix-org/travis/e2e-docs
...
Minor updates to e2e test instructions on Windows
2020-04-17 09:54:58 -06:00
Travis Ralston and GitHub
001e4c13bc
Merge pull request #4433 from matrix-org/travis/fix-e2e-tests
...
Turn the end-to-end tests back on and fix the lazy-loading tests
2020-04-16 22:38:41 -06:00
Travis Ralston
a5f5f759cb
Create unencrypted rooms by default in e2e-tests
...
Otherwise the lazy loading test will try to join the room after the encrypted messages have already been sent, making them invisible.
See https://github.com/vector-im/riot-web/issues/13226#issuecomment-614928362
2020-04-16 16:27:43 -06:00
Travis Ralston
6d46ef548e
Enable tests again to catch failures
2020-04-16 16:26:29 -06:00
Travis Ralston
0489dcc8da
Minor updates to e2e test instructions on Windows
2020-04-16 15:55:33 -06:00
Travis Ralston and GitHub
cd73f3736a
Merge pull request #4416 from matrix-org/travis/cross-sign-setting
...
Convert cross-signing feature flag to setting
2020-04-16 12:51:38 -06:00
Travis Ralston and GitHub
4e7dd74c22
Merge pull request #4429 from matrix-org/travis/xsign-flag-rel
...
[Release] Convert cross-signing flag to a setting
2020-04-16 12:50:54 -06:00
Travis Ralston
3614170906
Disable scripts in CI too
2020-04-16 12:47:25 -06:00
Travis Ralston
22533d3e6a
Disable scripts in CI too
2020-04-16 12:46:34 -06:00
Travis Ralston
c3f90ed289
Short-circuit all end to end tests
2020-04-16 12:42:42 -06:00
Travis Ralston
741368350c
Track the issue number too
2020-04-16 12:42:32 -06:00
Travis Ralston
1deece3fb5
Short-circuit all end to end tests
2020-04-16 12:41:48 -06:00
Travis Ralston
4af33d91eb
Track the issue number too
2020-04-16 12:26:08 -06:00
Travis Ralston
d04af1f3a8
Disable e2e tests for now
2020-04-16 12:24:04 -06:00
Travis Ralston
8b5a8f163f
Disable e2e tests for now
2020-04-16 12:23:22 -06:00
Travis Ralston
2451e0b873
Wait a bit before continuing with the passphrase
...
The continue button is probably no-oping due to being disabled.
2020-04-16 12:13:35 -06:00
Travis Ralston
f4a5361b14
Wait a bit before continuing with the passphrase
...
The continue button is probably no-oping due to being disabled.
2020-04-16 12:13:05 -06:00
Travis Ralston
5769b07a92
Select the right continue button
...
There's no buttons in the field.
2020-04-16 12:04:48 -06:00
Travis Ralston
597f97e1d8
Select the right continue button
...
There's no buttons in the field.
2020-04-16 12:04:01 -06:00
Travis Ralston
2432f77b72
Blind attempt at fixing the end to end tests
2020-04-16 11:48:45 -06:00
Travis Ralston
25fa675f88
Blind attempt at fixing the end to end tests
2020-04-16 11:46:29 -06:00
Travis Ralston
45b6b95d44
Appease the linter
2020-04-16 11:27:09 -06:00
Travis Ralston
2ffb5be5cd
Remove UI to change the cross-signing setting
2020-04-16 11:26:56 -06:00
Travis Ralston
b5b4bdbf3d
Clean up setting definition to follow surrounding practices
...
It's not perfect, but we're at least okay with it.
2020-04-16 11:26:51 -06:00
Travis Ralston
2d395d8dd1
Convert cross-signing feature flag to setting
...
This is intended as a temporary measure until we're comfortable with removing the flag entirely.
2020-04-16 11:26:42 -06:00
Travis Ralston
0fcaaab1d0
Appease the linter
2020-04-16 11:18:54 -06:00
Travis Ralston
54f8ba4d80
Remove UI to change the cross-signing setting
2020-04-16 11:15:12 -06:00
Travis Ralston
b5130ca5dc
Clean up setting definition to follow surrounding practices
...
It's not perfect, but we're at least okay with it.
2020-04-16 11:12:47 -06:00
Travis Ralston
db749519e7
Merge branch 'develop' into travis/cross-sign-setting
2020-04-16 11:06:26 -06:00
Travis Ralston
b4e2daaf46
Convert cross-signing feature flag to setting
...
This is intended as a temporary measure until we're comfortable with removing the flag entirely.
2020-04-15 13:18:42 -06:00
Travis Ralston
77bdde4021
Merge branch 'travis/moar-jitsi' into travis/addwidget-improvements
2020-04-14 12:58:16 -06:00
Travis Ralston and GitHub
4fe16b1b84
Merge branch 'develop' into travis/moar-jitsi
2020-04-14 12:57:28 -06:00
Travis Ralston and GitHub
36fea4d487
Merge pull request #4378 from matrix-org/travis/expanding-widgets
...
Minimize widgets by default
2020-04-14 12:56:10 -06:00
Travis Ralston and GitHub
f0a2f5dd4f
Merge pull request #4380 from matrix-org/travis/widget-complaints
...
Add comments to highlight where we'll need m.widget support
2020-04-14 12:55:49 -06:00
Travis Ralston and GitHub
8f49ed664f
Merge pull request #4383 from matrix-org/travis/plural-delete
...
Use singular text on 'delete sessions' button for SSO
2020-04-09 16:39:59 -06:00
Travis Ralston
879b4e15e5
Use singular text on 'delete sessions' button for SSO
...
Missed in https://github.com/matrix-org/matrix-react-sdk/pull/4357
Not a release blocker at this time.
2020-04-09 16:18:12 -06:00
Travis Ralston
b518fdd8ee
i18n
2020-04-09 16:05:31 -06:00
Travis Ralston
0165ff0bc9
Allow iframes and Jitsi URLs in /addwidget
...
Fixes https://github.com/vector-im/riot-web/issues/12784
2020-04-09 16:03:40 -06:00
Travis Ralston
7d3fc60d64
Merge branch 'travis/moar-jitsi' into travis/addwidget-improvements
2020-04-09 15:27:39 -06:00
Travis Ralston
4510499987
Fix widgets for all other sources too
2020-04-09 15:25:11 -06:00
Travis Ralston
b4b0c4c6df
Add comments to highlight where we'll need m.widget support
...
For https://github.com/vector-im/riot-web/issues/13111
2020-04-09 15:14:07 -06:00
Travis Ralston
dc92f557fd
Support m.jitsi-typed widgets as Jitsi widgets
...
Fixes https://github.com/vector-im/riot-web/issues/9268
2020-04-09 15:11:57 -06:00
Travis Ralston and GitHub
4d461c6d87
Merge pull request #4377 from matrix-org/travis/sticker-data
...
Pass widget data through from sticker picker
2020-04-09 14:48:33 -06:00
Travis Ralston
34be024b21
Minimize widgets by default
...
Fixes https://github.com/vector-im/riot-web/issues/12921
2020-04-09 14:47:20 -06:00
Travis Ralston and GitHub
ef8c5033ee
Merge pull request #4376 from matrix-org/travis/jitsi-end
...
Obliterate widgets when they are minimized
2020-04-09 14:40:40 -06:00
Travis Ralston
3dc03ba089
Pass widget data through from sticker picker
...
This allows for sticker pickers to have custom template variables.
Fixes https://github.com/vector-im/riot-web/issues/6716
2020-04-09 14:40:23 -06:00
Travis Ralston
db3c7a8f1c
Obliterate widgets when they are minimized
...
Fixes https://github.com/vector-im/riot-web/issues/12810
We do this to all widgets as we can't guarantee what sorts of other widgets might need similar treatment.
2020-04-09 14:31:46 -06:00
Travis Ralston and GitHub
e30e245bc7
Merge pull request #4366 from matrix-org/travis/encode-widgets
...
Fix encoding of widget arguments
2020-04-08 13:12:03 -06:00
Travis Ralston
b5aaae1c27
Fix encoding of widget arguments
...
Fixes https://github.com/vector-im/riot-web/issues/12985
This is done by using a more modern API and de-encoding dollar signs.
2020-04-08 12:58:52 -06:00
Travis Ralston and GitHub
fc28492a2a
Merge pull request #4360 from matrix-org/travis/fix-share-dialog
...
Fix share dialog correctly
2020-04-07 15:34:33 -06:00
Travis Ralston
900a05366e
Fix share dialog correctly
...
componentDidMount fires too late for this dialog, so we need to set ourselves up in the constructor.
Fixes https://github.com/vector-im/riot-web/issues/13068
2020-04-07 15:22:38 -06:00